MIME-Version: 1.0
In-Reply-To: <555B9438.9020404@codeaurora.org>
References: <1431763110-443-1-git-send-email-yingjoe.chen@mediatek.com>
	<1431763110-443-6-git-send-email-yingjoe.chen@mediatek.com>
	<555B9438.9020404@codeaurora.org>
Date: Wed, 20 May 2015 10:43:36 +0200
Message-ID: <CABuKBeKgWc8YJeacr1VeVaOQ1hzpqdTskarDJk6W2AdfWqQ9nw@mail.gmail.com>
Subject: Re: [PATCH v2 5/9] ARM: mediatek: enable gpt6 on boot up to make arch
 timer working
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Russell King <linux@arm.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Pawel Moll <pawel.moll@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marc Carino <marc.ceeeee@gmail.com>, Rob Herring <robh+dt@kernel.org>,
        linux-mediatek@lists.infradead.org,
        Sascha Hauer <kernel@pengutronix.de>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1820
Lines: 60

2015-05-19 21:51 GMT+02:00 Stephen Boyd <sboyd@codeaurora.org>:
> On 05/16/15 00:58, Yingjoe Chen wrote:
>> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
>> index a954900..6b38d67 100644
>> --- a/arch/arm/mach-mediatek/mediatek.c
>> +++ b/arch/arm/mach-mediatek/mediatek.c
>> @@ -16,6 +16,34 @@
>>   */
>>  #include <linux/init.h>
>>  #include <asm/mach/arch.h>
>> +#include <linux/of.h>
>> +#include <linux/clk-provider.h>
>> +#include <linux/clocksource.h>
>> +
>> +
>> +#define GPT6_CON_MT65xx 0x10008060
>> +#define GPT_ENABLE      0x31
>> +
>> +static void __init mediatek_timer_init(void)
>> +{
>> +     void __iomem *gpt_base = 0;
>
>  = NULL ?
>
>> +
>> +     if (of_machine_is_compatible("mediatek,mt6589") ||
>> +         of_machine_is_compatible("mediatek,mt8135") ||
>> +         of_machine_is_compatible("mediatek,mt8127")) {
>> +             /* turn on GPT6 which ungates arch timer clocks */
>> +             gpt_base = ioremap(GPT6_CON_MT65xx, 0x04);
>> +     }
>> +
>> +     /* enabel clock and set to free-run */
>
> s/enabel/enable/
>
>> +     if (gpt_base) {
>> +             writel(GPT_ENABLE, gpt_base);
>> +             iounmap(gpt_base);
>> +     }
>> +
>
> Why not join the two conditions together?

The initial patch supposed that on different SoCs GPT6_CON register
would be mapped on different addresses, but that seems not the case.
So yes, we can join the two conditions together.

Yingjoe, can you add the changes in the next series or do you want me to do it?

Thanks,
Matthias

-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/