Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbbETJBI (ORCPT ); Wed, 20 May 2015 05:01:08 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:56105 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbbETJBC (ORCPT ); Wed, 20 May 2015 05:01:02 -0400 Message-ID: <1432112455.21715.70.camel@x220> Subject: Re: [PATCH v1 03/12] crypto: qat - address recursive dependency when fw signing is enabled From: Paul Bolle To: Herbert Xu Cc: "Luis R. Rodriguez" , Rusty Russell , David Howells , Ming Lei , Seth Forshee , Kyle McMartin , Andrew Morton , Greg Kroah-Hartman , Kees Cook , Casey Schaufler , Takashi Iwai , Matthew Garrett , "wireless-regdb@lists.infradead.org" , linux-wireless , jlee@suse.com, "linux-kernel@vger.kernel.org" , Bruce Allan , Tadeusz Struk , John Griffin Date: Wed, 20 May 2015 11:00:55 +0200 In-Reply-To: <20150520024925.GA7021@gondor.apana.org.au> References: <1430988137.8171.58.camel@x220> <1431021995.8171.97.camel@x220> <20150518200100.GY23057@wotan.suse.de> <1431981930.9091.29.camel@x220> <20150519000921.GA23057@wotan.suse.de> <1432022535.9091.48.camel@x220> <20150519154630.GB23057@wotan.suse.de> <20150519225945.GB5718@gondor.apana.org.au> <20150519230355.GA5853@gondor.apana.org.au> <20150520024925.GA7021@gondor.apana.org.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1607 Lines: 37 On Wed, 2015-05-20 at 10:49 +0800, Herbert Xu wrote: > On Tue, May 19, 2015 at 04:05:43PM -0700, Luis R. Rodriguez wrote: > > Well that's be true if FW_LOADER was easy to disable, but its not. You > > really gotta try hard to disable it. Not only does it require EXPERT > > but also EMBEDDED. How does that require EMBEDDED? > I think its fair to say if you disable FW_LOADER > > you know what you are doing and its fair for us then to remove such > > selects or depends. Thoughts? > > Sure. I can live with killing all selects/depends on FW_LOADER. (Having reread my mail from the day before yesterday once more, I note that my suggestion to drop the selects is rather circular. Because it's the selects that also make it hard to disable FW_LOADER.) So the message is something like: "If you set EXPERT and disable FW_LOADER you're on your own. You have to figure out yourself whether the configuration you chose builds or actually runs correctly. Don't expect us to care about the issues you run into. And that goes for randconfig builds that happen to do that too." That might be an acceptable thing to say. The help for EXPERT is pretty clear. But I do wonder if this is a first or if this has been done before (ie, whether there's a precedent). Because, generally speaking, people try rather hard to prevent pointless configurations. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/