Message-ID: <555C7102.8060207@nvidia.com>
Date: Wed, 20 May 2015 12:33:22 +0100
From: Jon Hunter <jonathanh@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Alexandre Courbot <acourbot@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Jiri Slaby" <jslaby@suse.cz>
CC: <linux-serial@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: tegra: Fix memory leak on DMA setup failure
References: <1432120864-23916-1-git-send-email-jonathanh@nvidia.com> <555C6F38.50603@nvidia.com>
In-Reply-To: <555C6F38.50603@nvidia.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 827
Lines: 25


On 20/05/15 12:25, Jon Hunter wrote:
> 
> On 20/05/15 12:21, Jon Hunter wrote:
>> If the call to dmaengine_slave_config() fails, then the DMA buffer will
>> not be freed/unmapped. Fix this by moving the code that stores the
>> address of the buffer in the tegra_uart_port structure to before the
>> call to dmaengine_slave_config().
> 
> By the way, just to be clear, I did try to fix this before [1], but
> failed :-(

To be doubly clear, this is targeted to be applied on top of the
previous patch [1] which is now in linux-next.

Jon

> [1] https://lkml.org/lkml/2015/5/5/802

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/