Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbbETMNq (ORCPT ); Wed, 20 May 2015 08:13:46 -0400 Received: from foss.arm.com ([217.140.101.70]:37958 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbbETMNn (ORCPT ); Wed, 20 May 2015 08:13:43 -0400 Date: Wed, 20 May 2015 13:15:24 +0100 From: Marc Zyngier To: Robert Richter Cc: Thomas Gleixner , Jason Cooper , Tirumalesh Chalamarla , Radha Mohan Chintakuntla , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Robert Richter Subject: Re: [PATCH 3/4] arm64: gicv3: its: Read typer register outside the loop Message-ID: <20150520131524.09d325fe@why.wild-wind.fr.eu.org> In-Reply-To: <1430686172-18222-4-git-send-email-rric@kernel.org> References: <1430686172-18222-1-git-send-email-rric@kernel.org> <1430686172-18222-4-git-send-email-rric@kernel.org> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 52 On Sun, 3 May 2015 21:49:31 +0100 Robert Richter wrote: > From: Robert Richter > > No need to read the typer register in the loop. Values do not change. > > Signed-off-by: Robert Richter Fair enough. Acked-by: Marc Zyngier M. > --- > drivers/irqchip/irq-gic-v3-its.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index a2619a1d5bb3..916c4724c771 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -803,6 +803,8 @@ static int its_alloc_tables(struct its_node *its) > int psz = SZ_64K; > u64 shr = GITS_BASER_InnerShareable; > u64 cache = GITS_BASER_WaWb; > + u64 typer = readq_relaxed(its->base + GITS_TYPER); > + u32 ids = GITS_TYPER_DEVBITS(typer); > > for (i = 0; i < GITS_BASER_NR_REGS; i++) { > u64 val = readq_relaxed(its->base + GITS_BASER + i * 8); > @@ -826,9 +828,6 @@ static int its_alloc_tables(struct its_node *its) > * For other tables, only allocate a single page. > */ > if (type == GITS_BASER_TYPE_DEVICE) { > - u64 typer = readq_relaxed(its->base + GITS_TYPER); > - u32 ids = GITS_TYPER_DEVBITS(typer); > - > order = get_order((1UL << ids) * entry_size); > if (order >= MAX_ORDER) { > order = MAX_ORDER - 1; -- Without deviation from the norm, progress is not possible. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/