Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbETMrX (ORCPT ); Wed, 20 May 2015 08:47:23 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:6890 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbbETMrW (ORCPT ); Wed, 20 May 2015 08:47:22 -0400 Message-ID: <555C821F.7090104@atmel.com> Date: Wed, 20 May 2015 14:46:23 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexandre Belloni CC: , , Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [PATCH] ARM: at91/dt: at91sam9x5: fix usart1 sck pin definition References: <1432125370-21092-1-git-send-email-nicolas.ferre@atmel.com> <20150520124154.GB3907@piout.net> In-Reply-To: <20150520124154.GB3907@piout.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 44 Le 20/05/2015 14:41, Alexandre Belloni a ?crit : > On 20/05/2015 at 14:36:10 +0200, Nicolas Ferre wrote : >> SCK1 pin is pioC 29. Comment was okay. >> >> Signed-off-by: Nicolas Ferre >> --- >> arch/arm/boot/dts/at91sam9x5.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi >> index 9c236c317eeb..dfdbdf43860e 100644 >> --- a/arch/arm/boot/dts/at91sam9x5.dtsi >> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi >> @@ -505,7 +505,7 @@ >> >> pinctrl_usart1_sck: usart1_sck-0 { >> atmel,pins = >> - ; /* PC29 periph C */ >> + ; /* PC29 periph C */ > > I think you should remove the comment. As you can see, it didn't help ;) I agree, but didn't do it in this patch because the whole file is stuffed with these useless comments... We'd better do it in a single patch or... leave it like this... Bye, >> }; >> }; >> >> -- >> 2.1.3 >> > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/