Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752966AbbETNDT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 May 2015 09:03:19 -0400
Received: from casper.infradead.org ([85.118.1.10]:33117 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751272AbbETNDS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 May 2015 09:03:18 -0400
Date: Wed, 20 May 2015 15:03:12 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Stephane Eranian <eranian@google.com>, LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Paul Mackerras <paulus@samba.org>
Subject: Re: perf: fuzzer triggers NULL pointer derefreence in
 x86_schedule_events
Message-ID: <20150520130312.GL3644@twins.programming.kicks-ass.net>
References: <alpine.DEB.2.11.1504301448440.30050@vincent-weaver-1.umelst.maine.edu>
 <20150501125955.GF5029@twins.programming.kicks-ass.net>
 <CABPqkBRiAe3HmYN7vACH-8OPMOLXKrETY_8n0Hm3pyVcuLHfug@mail.gmail.com>
 <20150507124300.GK23123@twins.programming.kicks-ass.net>
 <alpine.DEB.2.11.1505181325110.32481@vincent-weaver-1.umelst.maine.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1505181325110.32481@vincent-weaver-1.umelst.maine.edu>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2340
Lines: 62

On Mon, May 18, 2015 at 01:40:31PM -0400, Vince Weaver wrote:
> On Thu, 7 May 2015, Peter Zijlstra wrote:
> 
> > On Mon, May 04, 2015 at 12:32:56PM -0700, Stephane Eranian wrote:
> > > I think it is more likely related to the bitmask (idxmsk).  But then
> > > it is always allocated with the constraint even with the HT bug
> > > workaround.  So most, likely the index is bogus and you touch outside
> > > the idxmsk[] array.
> > 
> > [428232.701319] BUG: unable to handle kernel NULL pointer dereference at           (null)
> > 
> > But the thing really tried to touch NULL, not some random address that
> > faulted.
> > 
> > As always, Vince has found us a good puzzle ;-)
> 
> so the Haswell machine turned up the following oops that looks related.
> 
> Yet again we are ending up with a NULL pointer in the constraint table 
> somehow.
> 
> This maps to 
> 
> static bool __perf_sched_find_counter(struct perf_sched *sched)
> 
>         c = sched->events[sched->state.event]->hw.constraint;
> 
>         /* Prefer fixed purpose counters */
> --->	if (c->idxmsk64 & (~0ULL << INTEL_PMC_IDX_FIXED)) {
> 
> ffffffff81029ce4:       48 8b 55 88             mov    -0x78(%rbp),%rdx
> ffffffff81029ce8:       48 8b 04 c2             mov    (%rdx,%rax,8),%rax
> ffffffff81029cec:       ba 20 00 00 00          mov    $0x20,%edx
> ffffffff81029cf1:       48 8b 98 98 01 00 00    mov    0x198(%rax),%rbx
> ffffffff81029cf8:       4c 85 23                test   %r12,(%rbx)
> 
> 
> [306672.100641] BUG: unable to handle kernel NULL pointer dereference at           (null)
> [306672.109653] IP: [<ffffffff81029cf8>] perf_assign_events+0xa8/0x290

So new in this release is:

static void intel_put_event_constraints(struct cpu_hw_events *cpuc,
					struct perf_event *event)
{
	...

	/* cleanup dynamic constraint */
	if (c && (c->flags & PERF_X86_EVENT_DYNAMIC))
		event->hw.constraint = NULL;
}

Which is the only place that value is ever cleared...

Now, I've not quite figured out how that can intersect with scheduling,
typically we only call put_event_constraints() when we're done with the
event.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/