Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696AbbETNJO (ORCPT ); Wed, 20 May 2015 09:09:14 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:40708 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237AbbETNJM (ORCPT ); Wed, 20 May 2015 09:09:12 -0400 Message-ID: <555C8743.6020708@ti.com> Date: Wed, 20 May 2015 18:38:19 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Bjorn Helgaas , Stanimir Varbanov CC: Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Russell King , Arnd Bergmann , , , , , , Mathieu Olivari , Srinivas Kandagatla Subject: Re: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY References: <1430743338-10441-1-git-send-email-svarbanov@mm-sol.com> <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> <554783CD.50708@ti.com> <55478F1A.3000401@mm-sol.com> <20150519224143.GS31666@google.com> In-Reply-To: <20150519224143.GS31666@google.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1628 Lines: 41 Hi Bjorn, On Wednesday 20 May 2015 04:11 AM, Bjorn Helgaas wrote: > On Mon, May 04, 2015 at 06:24:10PM +0300, Stanimir Varbanov wrote: >> On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: >>>> Add a PCIe PHY driver used by PCIe host controller driver >>>> on Qualcomm SoCs like Snapdragon 805. >>>> >>>> Signed-off-by: Stanimir Varbanov >>>> --- >>>> drivers/phy/Kconfig | 9 ++ >>>> drivers/phy/Makefile | 1 + >>>> drivers/phy/phy-qcom-pcie.c | 291 >>>> +++++++++++++++++++++++++++++++++++++++++++ >>> >>> Why do you need a new PHY driver for this? Why not use the existing QCOM >>> PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? >> >> I agree that on first glance there are similarities, but I'm not sure >> does the PHYs are the same IP blocks. Or at least they are different >> revisions which have too many differences. So trying to combine them >> will lead to more code than now. >> >> Either way I will try to understand how many the differences are. > > Ping, where are we with this? Should I wait for something else, or are you > convinced there's enough difference to warrant a new PHY driver, Kishon? I'd like to wait to see if Stanimir can use existing driver instead of creating a new driver. Cheers Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/