Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071AbbETNWi (ORCPT ); Wed, 20 May 2015 09:22:38 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:42820 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753747AbbETNWf (ORCPT ); Wed, 20 May 2015 09:22:35 -0400 X-IronPort-AV: E=Sophos;i="5.13,464,1427760000"; d="scan'208";a="266878542" Message-ID: <555C8A3D.9010105@citrix.com> Date: Wed, 20 May 2015 14:21:01 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Bob Liu , CC: , , , , Subject: Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support References: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> <1432127422-6797-2-git-send-email-bob.liu@oracle.com> In-Reply-To: <1432127422-6797-2-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 44 Hi, On 20/05/15 14:10, Bob Liu wrote: > --- > drivers/block/xen-blkback/blkback.c | 12 ++++ > drivers/block/xen-blkback/common.h | 3 +- > drivers/block/xen-blkback/xenbus.c | 85 +++++++++++++++++++++------- > drivers/block/xen-blkfront.c | 110 ++++++++++++++++++++++++++---------- > 4 files changed, 161 insertions(+), 49 deletions(-) > > diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c > index 713fc9f..057890f 100644 > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -84,6 +84,12 @@ MODULE_PARM_DESC(max_persistent_grants, > "Maximum number of grants to map persistently"); > > /* > + * Maximum number of pages to be used as the ring between front and backend > + */ > +unsigned int xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; We will soon support 64KB page granularity with ARM64, although the PV protocol will keep a 4KB page granularity. Can you clarify with granularity is used here? The one of the host or the one of the PV protocol? > +module_param_named(max_ring_page_order, xen_blkif_max_ring_order, int, S_IRUGO); > +MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used as the ring"); > +/* > * The LRU mechanism to clean the lists of persistent grants needs to > * be executed periodically. The time interval between consecutive executions > * of the purge mechanism is set in ms. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/