Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754211AbbETNY4 (ORCPT ); Wed, 20 May 2015 09:24:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754110AbbETNX4 (ORCPT ); Wed, 20 May 2015 09:23:56 -0400 Date: Wed, 20 May 2015 15:23:19 +0200 From: Andrea Arcangeli To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-api@vger.kernel.org, Pavel Emelyanov , Sanidhya Kashyap , zhang.zhanghailiang@huawei.com, Linus Torvalds , "Kirill A. Shutemov" , Andres Lagar-Cavilla , Dave Hansen , Paolo Bonzini , Rik van Riel , Mel Gorman , Andy Lutomirski , Hugh Dickins , Peter Feiner , "Dr. David Alan Gilbert" , Johannes Weiner , "Huangpeng (Peter)" Subject: Re: [PATCH 00/23] userfaultfd v4 Message-ID: <20150520132319.GN19097@redhat.com> References: <1431624680-20153-1-git-send-email-aarcange@redhat.com> <20150519143801.8ba477c3813e93a2637c19cf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519143801.8ba477c3813e93a2637c19cf@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2208 Lines: 52 Hi Andrew, On Tue, May 19, 2015 at 02:38:01PM -0700, Andrew Morton wrote: > On Thu, 14 May 2015 19:30:57 +0200 Andrea Arcangeli wrote: > > > This is the latest userfaultfd patchset against mm-v4.1-rc3 > > 2015-05-14-10:04. > > It would be useful to have some userfaultfd testcases in > tools/testing/selftests/. Partly as an aid to arch maintainers when > enabling this. And also as a standalone thing to give people a > practical way of exercising this interface. Agreed. I was also thinking about writing a trinity module for it, I wrote it for an older version but it was much easier to do that back then before we had ioctls, now it's more tricky because the ioctls requires the fd open first etc... it's not enough to just call a syscall with a flood of supervised-random params anymore. > What are your thoughts on enabling userfaultfd for other architectures, > btw? Are there good use cases, are people working on it, etc? powerpc should be enabled and functional already. There's not much arch dependent code in it, so in theory if the postcopy live migration patchset is applied to qemu, it should work on powerpc out of the box. Nobody tested it yet but I don't expect trouble on the kernel side. Adding support for all other archs is just a few liner patch that defines the syscall number. I didn't do that out of tree because every time a new syscall materialized I would get more rejects during rebase. > Also, I assume a manpage is in the works? Sooner rather than later > would be good - Michael's review of proposed kernel interfaces has > often been valuable. Yes, the manpage was certainly planned. It would require updates as we keep adding features (like the wrprotect tracking, the non-cooperative usage, and extending the availability of the ioctls to tmpfs). We can definitely write a manpage with the current features. Ok, so I'll continue working on the testcase and on the manpage. Thanks!! Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/