Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752874AbbETNo1 (ORCPT ); Wed, 20 May 2015 09:44:27 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:34734 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720AbbETNoY (ORCPT ); Wed, 20 May 2015 09:44:24 -0400 MIME-Version: 1.0 In-Reply-To: <72933a3c053b445e7998c818b7a73317fa1e2d8a.1432031565.git.stwiss.opensource@diasemi.com> References: <72933a3c053b445e7998c818b7a73317fa1e2d8a.1432031565.git.stwiss.opensource@diasemi.com> From: Rob Herring Date: Wed, 20 May 2015 08:44:03 -0500 Message-ID: Subject: Re: [RESEND PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey To: S Twiss Cc: Ian Campbell , Kumar Gala , Lee Jones , Mark Rutland , Pawel Moll , Rob Herring , DT , David Dajun Chen , Dmitry Torokhov , INPUT , LKML , Samuel Ortiz , Support Opensource Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3535 Lines: 92 On Tue, May 19, 2015 at 5:32 AM, S Twiss wrote: > From: Steve Twiss > > Add device tree bindings for the DA9063 OnKey driver > > Acked-by: Lee Jones > nit: remove blank line here. I would think a long key press would be a h/w powerdown rather than a key event as how do you poweroff/reset a hung system? That doesn't really affect the binding though, so: Acked-by: Rob Herring Rob > Signed-off-by: Steve Twiss > > --- > Version History > > Changes in V4 > - No change > > Changes in V3 > - No change > > Changes in V2 > - Remove the circular dependency comment linking patches in the main e-mail > - Search and replace 'keyword' with 'property' in onkey sub-node description > - Reformat onkey sub-node content to move the description for key-power into > a new optional properties sub-section so it has a more promiment position > > This patch applies against linux-next and v4.1-rc3 > > > Documentation/devicetree/bindings/mfd/da9063.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/da9063.txt b/Documentation/devicetree/bindings/mfd/da9063.txt > index 42c6fa6..05b21bc 100644 > --- a/Documentation/devicetree/bindings/mfd/da9063.txt > +++ b/Documentation/devicetree/bindings/mfd/da9063.txt > @@ -5,6 +5,7 @@ DA9093 consists of a large and varied group of sub-devices (I2C Only): > Device Supply Names Description > ------ ------------ ----------- > da9063-regulator : : LDOs & BUCKs > +da9063-onkey : : On Key > da9063-rtc : : Real-Time Clock > da9063-watchdog : : Watchdog > > @@ -51,6 +52,18 @@ Sub-nodes: > the DA9063. There are currently no entries in this binding, however > compatible = "dlg,da9063-rtc" should be added if a node is created. > > +- onkey : This node defines the OnKey settings for controlling the key > + functionality of the device. The node should contain the compatible property > + with the value "dlg,da9063-onkey". > + > + Optional onkey properties: > + > + - dlg,disable-key-power : Disable power-down using a long key-press. If this > + entry exists the OnKey driver will remove support for the KEY_POWER key > + press. If this entry does not exist then by default the key-press > + triggered power down is enabled and the OnKey will support both KEY_POWER > + and KEY_SLEEP. > + > - watchdog : This node defines settings for the Watchdog timer associated > with the DA9063. There are currently no entries in this binding, however > compatible = "dlg,da9063-watchdog" should be added if a node is created. > @@ -73,6 +86,11 @@ Example: > compatible = "dlg,da9063-watchdog"; > }; > > + onkey { > + compatible = "dlg,da9063-onkey"; > + dlg,disable-key-power; > + }; > + > regulators { > DA9063_BCORE1: bcore1 { > regulator-name = "BCORE1"; > -- > end-of-patch for RESEND PATCH V4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/