Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbbETNt6 (ORCPT ); Wed, 20 May 2015 09:49:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37632 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633AbbETNtw (ORCPT ); Wed, 20 May 2015 09:49:52 -0400 Message-ID: <77d452918f9dad547ddf728022f82fb0.squirrel@www.codeaurora.org> In-Reply-To: <1432110592.21715.50.camel@x220> References: <1432043231-31102-1-git-send-email-ygardi@codeaurora.org> <1432043231-31102-3-git-send-email-ygardi@codeaurora.org> <1432110592.21715.50.camel@x220> Date: Wed, 20 May 2015 13:49:50 -0000 Subject: Re: [PATCH v1 2/3] scsi: ufs-qcom: fix compilation warning if compiled as a module From: ygardi@codeaurora.org To: "Paul Bolle" Cc: "Yaniv Gardi" , james.bottomley@hansenpartnership.com, kishon@ti.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org, gbroner@codeaurora.org, dovl@codeaurora.org, "Vinayak Holikatti" , "James E.J. Bottomley" User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 42 > On Tue, 2015-05-19 at 16:47 +0300, Yaniv Gardi wrote: >> --- a/drivers/scsi/ufs/ufs-qcom.c >> +++ b/drivers/scsi/ufs/ufs-qcom.c >> @@ -885,7 +885,7 @@ out: >> >> #define ANDROID_BOOT_DEV_MAX 30 >> static char android_boot_dev[ANDROID_BOOT_DEV_MAX]; >> -static int get_android_boot_dev(char *str) >> +static int __maybe_unused get_android_boot_dev(char *str) >> { >> strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX); >> return 1; > > Wouldn't it be clearer to wrap these few lines (until after the > __setup() macro) with #ifndef MODULE? > > And I think get_android_boot_dev() could be marked __init. Because if > it's built-in it will never be called after the kernel has finished > booting, right? > That's correct. I will upload an update to this patch. I accept both comments #ifndef MODULE is indeed clearer and __init flag as well, since get_android_boot_dev() will not be called again after booting finished. > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/