Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbbETOYj (ORCPT ); Wed, 20 May 2015 10:24:39 -0400 Received: from mail-bl2on0053.outbound.protection.outlook.com ([65.55.169.53]:18348 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752268AbbETOYK (ORCPT ); Wed, 20 May 2015 10:24:10 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none; Date: Wed, 20 May 2015 07:23:58 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Masahiro Yamada CC: , Michal Simek , Linus Walleij , , Subject: Re: [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function Message-ID: <20150520142358.GS31550@xsjsorenbubuntu> References: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21556.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC010;1:9PtYrTgp3tNSWlAOz9xYu9klkly5qvr0joMpAGE3aZ/P49JEd3Ff91KtpwCcpIdrr2iZImNVR3dsXp09ubGEHySDSGx/cQR/Tg//lhw1VGuQT/i9D+PZ6qZaOow6SCGdPNR+SRf+LwU5EBTyg75TgGH9Ju+M4ykD4Eaz9SaXcmdWE2TCtvLxs12vfkSubcJ4nBFnBL/ulgd1aEQg9+ohl+V2t+yaxH5LvOEnObDqulJdeZiv4OJ+ZjPkTp46Tni8AiMohoDUG/aLl8kyHOdWV7e41h3MOu1LQTIwMLJZGn3H7k4TJxuU1rBuZWZfhaew X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(51704005)(199003)(189002)(164054003)(24454002)(377424004)(77156002)(36386004)(6806004)(86362001)(50466002)(64706001)(85182001)(87936001)(4001350100001)(57986006)(63266004)(76506005)(46102003)(76176999)(2950100001)(4001540100001)(92566002)(81156007)(77096005)(50986999)(106466001)(33656002)(23676002)(110136002)(5001960100002)(189998001)(5001860100001)(5001830100001)(5001920100001)(85202003)(33716001)(47776003)(54356999)(62966003)(83506001)(19580395003)(19580405001)(107986001)(5001870100001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB003;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB003;2:lu+J5gHBhQ3wdoRYbyvPqXU3K+f4XBSe9rInIyi47/VvHD/Bbunu0ZuZWrO1KJLs;2:wxyaSHIfaCEp/iS6+MTuehqd7kw9qqfJKSkbMpB5b+DjEjAhLA6jePaI75AGqS5pAEh/yIHi+di1JES8aZIhma0h075GyfE83DaBR2775NenEiss9qmUNU7wHWmnofY1SFU4j33lm2gf15clzNBN5sTIT1mrFeggBq1azZS4bMwap5Bm/mV/CRj4YuA1k+J9Au807Vqdqolb5vdHR8vRujP+RDem+Kd1odemvgoN01QPHQxBzi+V4lMRRMKvWI5f;6:crDNZlOUKmfPFy6mHExrTe3Kx2CTCVzzdIvUZbi3K6bwqOz7DJxs6kQklV2gfZVSXUvAgEACvHRrSMUCVqJHWNT6RChizCYK2FlxBfy+ewVlL0qu6se1BFR1dvED4g6dVzQOwidlkS5xjX+TC6Bd9/Uoyh1OpN0UeXXwfqgfdx4ihSyEU4OS5ZlKUjQqwymUinWjrUmHrUPMJhJPw8Gybv4oYLYKvwxgFkS2na1CblVMWeD7YN6OlrAyl+bIYi8rGmPM+ZRNzuHI0HYbZoLioKCPqZXm8l5oLrh5IAc9FBin9PToGPTGMgSwxW7h5c+426op+MeJ8hwjyV0o0Ely6Yq7jgpDYmRGwQyesHPbquUPldGGXczOcHrEFzVy+thac3B7a3T0uVMxHnL5LY4AdfSH+OI7IPAdbmh5mYqdMCPGx/ZVvg+UgICrApMwh6YRdfVyHqehxP8Zkzr/XD70akQpY2//Jxu6Y/euFziJR3kS0/QABCw5tBs+qpiMNrf9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB003; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY2FFO11HUB003;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB003; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB003;3:x9pdbEbzyiuCyQifZO7hr9vOnlIms/NPakfec388ohDPxixzhksvkXJtF4+eP9473r/sgublQATXq91mFEOETyCDmLiGMWeLLejpvily+N5s4dn3nJjFedObeEWIEvGsBYetK99iuAL6gvTGDxo3nzrvG2AKGNhRskGStlAJUCLEVjnjFzIUXhXMY0KQu1Dm7i6A9FJRKpmZUp7b/5nBIpBrSewo5gFz6AbThOGSp1SdMbNIBi9Q/Pq1o8xaxCm7ROglb1npUnpG1EkhKaAZFgFa6G31yXZUbsjpGNEY5Nk= X-Forefront-PRVS: 0582641F53 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJGRk8xMUhVQjAwMzs5OlNKbmNGTFcrby9ZM3c3dDB3U2RXcDY1Yk1Y?= =?utf-8?B?Y3VmVzVlTEE5Q01kRnl6ajJHMThHamVSNVlTVG1IWGkySmxNemF5Vm9zTGdR?= =?utf-8?B?REZsTENOTHA2b0dkcEN0dCtuSzlCZk5jNi9wRiszUWZjSG5CVjgvcEl5Smdw?= =?utf-8?B?RFI4VlZtQ1p1NzRDMnNxOUxmSW9xR3dCSmJPOWJLb2VXTGx5R3A2VG13YWRh?= =?utf-8?B?NFcyVDlsUG04MVZlVlhWQkFSZEh5dUpuemFXZGltSGQ2dzNSS3A0SkFPZVlN?= =?utf-8?B?aldxQk82WUxYeG9kWTV6anIxM1V4bXNBbld6RzJvdElZTWVaS0dMTXVUd3JY?= =?utf-8?B?cjVzM2lkcUFDQTR0WXFCODNobmFZTzlIM3IzV2NDZVJ0SkYwNGJZN1FUUEZs?= =?utf-8?B?WDJTYUFmUFJnRmtVcHNlRkxGODEyR0Z1QTBjZkx1L3FUaGtiYXN2c2NkWlNw?= =?utf-8?B?MDJPN0dpYkU4V0w3T1NOUXhDOWVnR3dBK3hrMndiOExMTEE0eW5iSnp6alBM?= =?utf-8?B?MnhwQjBUR05OeGttYjdhckIxbVVJYXlXWWM5dDRWVXhxQ0xFRFVyQ3d6Z25h?= =?utf-8?B?NTNHV0hKNU1aQTlGcGdWMHk4U0dHeXVWZ2YyZ3Mra056aVFtOVUwVGVoSzFK?= =?utf-8?B?aTBLYVpZM2pCUStZVlBVRWljeWo1ckh4N1NMcWliWUJCNEdyR1dmYW1Tbndp?= =?utf-8?B?NTdmVlBWNFpsZUpqaEpRTXlDU2VLZndGdlV5MEFLWnkwdWVDYlRsTWRNUmdD?= =?utf-8?B?eWFrbmQwQU56U1FwUEZNS0NSdFFxL1Nmc3FOUTMwdmFDbGZ2SnhvanFTYVd5?= =?utf-8?B?VGdUVDhpUGlUVEdBK00zU2RIRnBCZ2liWjN3MGpNV3lnZWcycExWdFpHM3oy?= =?utf-8?B?RllIWnhlK3k2RzFQOG1pb3JzV3N1UGExWTJONWxQZVIxK2lGMzIvOUZZYkFP?= =?utf-8?B?ZzBhUXFkSVNGS3RHZ0p1Tlk0YnBlSUQ2KzkydW9wcndoeVdKV2xhYURxak5a?= =?utf-8?B?UnNuSjYvZVI3M2ZRNVROSTJYWURKTGNJdlNRVmN2SEJJNmpOTjdtMEhsWThN?= =?utf-8?B?RmovRU52Rm1nNFRCUEs5dEhpUUpLVW5OVE5MdzZHVElFNlpYMFdEclJRV2dm?= =?utf-8?B?bWFVcGplZW5EN0VINW5OS0xrb0xNZHB0UHpteDRQdUhNSVJ5UUNtL1JlWkgw?= =?utf-8?B?MlZacXc0VXIvc2dJR2FqWVZvODVuOU41WWgwSFlHakNCMGZoL1hzaWpmRzFP?= =?utf-8?B?R1M0Tk42VEdVNDVvOFdTRlFldVllbm9MS2JyS2wzOXFZQldsQWJJbjRlQmti?= =?utf-8?B?MCtIZnRjSFB5dmorRE56NFUyc2V0dDlIdFdnNHQzVkg0STllcnNaK3dpaUxK?= =?utf-8?B?ZzdZelF1b3VIZ0wzNjhmdG1xakFWL1F6bWNScG02eGhLSXcvRUVXZk1Id2pW?= =?utf-8?B?aThHakV5aFVRRmFzMTB5NGt0VHNhaEx6Z010NzNmOTJCNnJDdUJuNEZ2QVNZ?= =?utf-8?B?MkdpMGVpbzlVWnBoR3dmUHI1cHRNQ0NXaDdUS0k4WStvb1RlbzJkR2VZZ0R1?= =?utf-8?B?cTJ0NFBmQWd3SHhXMVBxSXZtc0pzQS9vSThEU3B6K1BWSkhTNVJjc1JWTy9k?= =?utf-8?B?V0p4MkNtekEvM1IrTFRGRzZHVVZXVzRESU50WkdwK1MrNm9HYmJBK3dnbW4r?= =?utf-8?Q?dSvmyo/UL/t+uPkA4w=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB003;3:8Dwknjm3k5RL3sFaUyke446ms8/1nqyBG//9H+IMkrFOdBPajmSU7zl3ulCeYaOewxttjBssxb3sBcbH5hW2Op+zZ5ZvZDppAAdOPERh21Cs2CeTRSFdWknnQVdA2enBilWS+de7bUgWQ3/q1CvLYQ==;10:EfoUxABGhh9fV1N5x2AZULLslJmeXFd1F6LITq83fdPtss5aHehTBZN3GtC1PAljJrXfqvS63016SdLXI4W/XnHijShweg3WfJcMKNuXaZU= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2015 14:24:07.9949 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB003 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 31 Hi Masahiro, On Wed, 2015-05-20 at 05:42PM +0900, Masahiro Yamada wrote: > > I sent the previous one to linux-serial by mistake. > I am resending to linux-gpio, dropping linux-serial. > Sorry for noise. > > > > Masahiro Yamada (2): > pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro > pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL For the series: Reviewed-by: Sören Brinkmann I'm not sure how severe the impact of these bugs is. It looks like the the current driver could corrupt the register for MIO pin0, am I right? It may be a good ides to add Fixes: add958cee967 "pinctrl: Add driver for Zynq" (I suspect that bug is there from the beginning) and ask Linus to consider this for stable. Thanks, Sören -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/