Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbbETPAf (ORCPT ); Wed, 20 May 2015 11:00:35 -0400 Received: from smtp.citrix.com ([66.165.176.89]:29274 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbbETPAe (ORCPT ); Wed, 20 May 2015 11:00:34 -0400 X-IronPort-AV: E=Sophos;i="5.13,464,1427760000"; d="scan'208";a="264428545" Message-ID: <555CA170.7070607@citrix.com> Date: Wed, 20 May 2015 16:00:00 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: =?windows-1252?Q?Roger_Pau_Monn=E9?= , Julien Grall , Bob Liu , CC: , , , Subject: Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support References: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> <1432127422-6797-2-git-send-email-bob.liu@oracle.com> <555C8A3D.9010105@citrix.com> <555CA0B9.9050108@citrix.com> In-Reply-To: <555CA0B9.9050108@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 44 On 20/05/15 15:56, Roger Pau Monn? wrote: > El 20/05/15 a les 15.21, Julien Grall ha escrit: >> Hi, >> >> On 20/05/15 14:10, Bob Liu wrote: >>> --- >>> drivers/block/xen-blkback/blkback.c | 12 ++++ >>> drivers/block/xen-blkback/common.h | 3 +- >>> drivers/block/xen-blkback/xenbus.c | 85 +++++++++++++++++++++------- >>> drivers/block/xen-blkfront.c | 110 ++++++++++++++++++++++++++---------- >>> 4 files changed, 161 insertions(+), 49 deletions(-) >>> >>> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c >>> index 713fc9f..057890f 100644 >>> --- a/drivers/block/xen-blkback/blkback.c >>> +++ b/drivers/block/xen-blkback/blkback.c >>> @@ -84,6 +84,12 @@ MODULE_PARM_DESC(max_persistent_grants, >>> "Maximum number of grants to map persistently"); >>> >>> /* >>> + * Maximum number of pages to be used as the ring between front and backend >>> + */ >>> +unsigned int xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; >> >> We will soon support 64KB page granularity with ARM64, although the PV >> protocol will keep a 4KB page granularity. >> >> Can you clarify with granularity is used here? The one of the host or >> the one of the PV protocol? > > It's using 4K pages, because those are then granted to the domain > handling the backend. It would be nice to add a word in the comment. Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/