Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932286AbbETPMj (ORCPT ); Wed, 20 May 2015 11:12:39 -0400 Received: from www.linutronix.de ([62.245.132.108]:33428 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932133AbbETPMe (ORCPT ); Wed, 20 May 2015 11:12:34 -0400 Date: Wed, 20 May 2015 17:12:12 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Simon Horman , Magnus Damm , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [RFC v1 10/25] sh: intc: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc In-Reply-To: <1432116013-25902-11-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-11-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 45 On Wed, 20 May 2015, Jiang Liu wrote: > Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we > already have a pointer to corresponding irq_desc. > > Also replace generic_handle_irq with generic_handle_irq_desc() to avoid > looking up irq_desc again. > > Signed-off-by: Jiang Liu > --- > drivers/sh/intc/core.c | 2 +- > drivers/sh/intc/virq.c | 14 ++++++++------ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c > index 81f22980b2de..e4ca964ca840 100644 > --- a/drivers/sh/intc/core.c > +++ b/drivers/sh/intc/core.c > @@ -67,7 +67,7 @@ void intc_set_prio_level(unsigned int irq, unsigned int level) > > static void intc_redirect_irq(unsigned int irq, struct irq_desc *desc) > { > - generic_handle_irq((unsigned int)irq_get_handler_data(irq)); > + generic_handle_irq_desc(irq, desc); This looks wrong. It's a redirector of irq to some other irq. redir_irq = (unsigned int)irq_get_handler_data(irq); which should be: redir_irq = (unsigned int)irq_desc_get_irq_handler_data(desc); And redir_irq is certainly not the same as irq. So this wants a conversion to irq_desc_get_irq_handler_data() first. That makes the irq argument unused. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/