Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbbETPSn (ORCPT ); Wed, 20 May 2015 11:18:43 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:35693 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbbETPSf (ORCPT ); Wed, 20 May 2015 11:18:35 -0400 MIME-Version: 1.0 In-Reply-To: <1430382149-1645-2-git-send-email-jszhang@marvell.com> References: <1430382149-1645-1-git-send-email-jszhang@marvell.com> <1430382149-1645-2-git-send-email-jszhang@marvell.com> Date: Wed, 20 May 2015 20:48:34 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] PCI: designware: consolidate outbound iATU programming functions From: Pratyush Anand To: Jisheng Zhang Cc: Jingoo Han , Bjorn Helgaas , Minghuan.Lian@freescale.com, fabrice.gasnier@st.com, "linux-pci@vger.kernel.org" , linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 20 On Thu, Apr 30, 2015 at 1:52 PM, Jisheng Zhang wrote: > Currently, the outbound iATU programming functions are similar, the only > difference is index, type, addr and size. This patch tries to consolidate > these functions into one. One side effect is it saves around 1700 bytes in > text: > > text data bss dec hex filename > 9276 204 4 9484 250c pcie-designware.o-before > 7532 204 4 7740 1e3c pcie-designware.o > > Signed-off-by: Jisheng Zhang looks fine to me. Acked-by: Pratyush Anand -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/