Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754613AbbETP0P (ORCPT ); Wed, 20 May 2015 11:26:15 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48685 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204AbbETP0I (ORCPT ); Wed, 20 May 2015 11:26:08 -0400 Date: Wed, 20 May 2015 16:25:48 +0100 From: Mark Brown To: =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: Ranjit Waghmode , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, harinik@xilinx.com, punnaia@xilinx.com, ran27jit@gmail.com Message-ID: <20150520152548.GH21577@sirena.org.uk> References: <1432106871-27232-1-git-send-email-ranjit.waghmode@xilinx.com> <1432106871-27232-2-git-send-email-ranjit.waghmode@xilinx.com> <20150520145552.GV31550@xsjsorenbubuntu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4LFBTxd4L5NLO6ly" Content-Disposition: inline In-Reply-To: <20150520145552.GV31550@xsjsorenbubuntu> X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 2/2] spi: Add support for Zynq Ultrascale+ MPSoC GQSPI controller X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 42 --4LFBTxd4L5NLO6ly Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2015 at 07:55:53AM -0700, S=F6ren Brinkmann wrote: > On Wed, 2015-05-20 at 12:57PM +0530, Ranjit Waghmode wrote: > > +static u32 zynqmp_gqspi_read(struct zynqmp_qspi *xqspi, u32 offset) > > +static inline void zynqmp_gqspi_write(struct zynqmp_qspi *xqspi, u32 o= ffset, > > + u32 val) > why are you wrapping (readl|writel)_relaxed? It's very common to wrap the lookup from driver data to the MMIO address. --4LFBTxd4L5NLO6ly Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVXKd8AAoJECTWi3JdVIfQ8AgH/iK6k95a816u3bD022ppAl1L +wP5nUi0SuummRSJbfLL+7cJYtOGHsCXQVnlpmeq2SW7g5kRMG19YRDYVkMNDM2/ 7fobrkdM7SLM5KhY1HWrzWcl4taMetbDJ3tC4zIb2gPv/2+7Ft9djMbfbOUyyTET 4w1ibjgxRJKj3vRB3DRAW0hmlbmU7n9dRU2Pfm1cKqngeV+ScSPEHYosszuRNLo/ dINYNv5kRLhg3pN9j8FsWao4yA4CF46Dnez39GFpoqjbHuA6RxMnRqf6nKrxCj1Y 5AP31E1oSOnHabXqncejjJzJX5Hje6ujimPo6fU5W+80mCLzmeBF0VdAfN26IJQ= =uZQr -----END PGP SIGNATURE----- --4LFBTxd4L5NLO6ly-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/