Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbbETUqe (ORCPT ); Wed, 20 May 2015 16:46:34 -0400 Received: from mailuogwhop.emc.com ([168.159.213.141]:39135 "EHLO mailuogwhop.emc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754710AbbETUmF (ORCPT ); Wed, 20 May 2015 16:42:05 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t4KKg1TZ030380 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t4KKg1TZ030380 From: Allen Hubbe To: linux-ntb@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jon Mason , Dave Jiang , Allen Hubbe Subject: [PATCH 10/16] ntb_transport: don't advance rx on link down Date: Wed, 20 May 2015 11:41:11 -0400 Message-Id: <5613ceb692dd7a5973d0b8d3269cc50a5b0721ee.1432135632.git.Allen.Hubbe@emc.com> X-Mailer: git-send-email 2.4.0.rc0.44.g244209c.dirty In-Reply-To: References: In-Reply-To: References: X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd04.lss.emc.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 30 On link down, don't advance RX index to the next entry. The next entry should never be valid after receiving the link down flag. Signed-off-by: Allen Hubbe --- drivers/ntb/ntb_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 8a6db1a..9b4e240 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -1211,8 +1211,7 @@ static int ntb_process_rxc(struct ntb_transport_qp *qp) dev_dbg(&qp->ndev->pdev->dev, "link down flag set\n"); ntb_qp_link_down(qp); hdr->flags = 0; - iowrite32(qp->rx_index, &qp->rx_info->entry); - return 0; + return -EAGAIN; } if (hdr->ver != (u32)qp->rx_pkts) { -- 2.4.0.rc0.43.gcf8a8c6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/