Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932519AbbETPs4 (ORCPT ); Wed, 20 May 2015 11:48:56 -0400 Received: from www.linutronix.de ([62.245.132.108]:33790 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932494AbbETPsw (ORCPT ); Wed, 20 May 2015 11:48:52 -0400 Date: Wed, 20 May 2015 17:48:19 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Russell King , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Hans Ulli Kroll , Shawn Guo , Sascha Hauer , Roland Stigge , Tony Lindgren , Rajendra Nayak , Paul Walmsley , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , Arnd Bergmann , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [RFC v1 15/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t In-Reply-To: <555CA929.3080306@linux.intel.com> Message-ID: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-16-git-send-email-jiang.liu@linux.intel.com> <555CA929.3080306@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 25 On Wed, 20 May 2015, Jiang Liu wrote: > On 2015/5/20 23:28, Thomas Gleixner wrote: > > On Wed, 20 May 2015, Jiang Liu wrote: > >> -static void locomo_handler(unsigned int irq, struct irq_desc *desc) > >> +static void locomo_handler(struct irq_desc *desc) > >> { > >> struct locomo *lchip = irq_desc_get_chip_data(desc); > >> + unsigned int irq; > >> int req, i; > > > > That leaves irq unitialized .... > That should be OK, 'irq' here is just a local variable. > Actually it may be changed as: > if (req) { > /* generate the next interrupt(s) */ > - irq = lchip->irq_base; > + unsigned int irq = lchip->irq_base; Indeed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/