Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838AbbETQGs (ORCPT ); Wed, 20 May 2015 12:06:48 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:34978 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbbETQGq (ORCPT ); Wed, 20 May 2015 12:06:46 -0400 MIME-Version: 1.0 In-Reply-To: <20150520140325.GN6325@pengutronix.de> References: <1431372206-1237-1-git-send-email-s.hauer@pengutronix.de> <1431372206-1237-4-git-send-email-s.hauer@pengutronix.de> <20150519103010.GA6325@pengutronix.de> <20150520140325.GN6325@pengutronix.de> Date: Wed, 20 May 2015 18:06:45 +0200 Message-ID: Subject: Re: [PATCH 3/5] soc: Mediatek: Add SCPSYS power domain driver From: Matthias Brugger To: Sascha Hauer Cc: Daniel Kurtz , "linux-arm-kernel@lists.infradead.org" , "open list:OPEN FIRMWARE AND..." , Kevin Hilman , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Sasha Hauer , "Rafael J. Wysocki" , Ulf Hansson Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 42 2015-05-20 16:03 GMT+02:00 Sascha Hauer : > On Tue, May 19, 2015 at 01:06:10PM +0200, Matthias Brugger wrote: >> 2015-05-19 12:30 GMT+02:00 Sascha Hauer : >> > >> > I'll check for errors next round. However, I cannot bail out in this >> > case since once pm_genpd_init() is called the domain cannot be >> > unregistered anymore. >> >> We should think of implementing this. >> I had a quick look on it, and from what I understand as long as you >> don't have any subdomains, devices and masters added, it's just >> deleting an element from a linked list. > > In my error path I would have subdomains added though, so I would need > that to be handled. Well we could bail out, when pm_genpd_add_subdomain fails. But the actual implementations don't do that neither at the moment. > >> Maybe we should split this in pm_genpd_prepare and pm_genpd_add, with >> the last one actually adding the generic_pm_domain to gpd_list. >> >> This way we could also get rid of the two for loops. > > Well, with pm_genpd_prepare and pm_genpd_add I would still need two > loops, one for preparing and one for adding. > > I'm not sure how useful it really is to be able to unregister power > domains. For now I suggest to continue with the domains that are > successfully registered. I'll look into it should the pm domain > maintainers request it. Alright. -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/