Message-ID: <555CCA54.6050502@fb.com>
Date: Wed, 20 May 2015 13:54:28 -0400
From: Josef Bacik <jbacik@fb.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
CC: <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH 2/5] trace-cmd: group schedule stacktraces together with
 --merge
References: <1431113344-22579-1-git-send-email-jbacik@fb.com>	<1431113344-22579-3-git-send-email-jbacik@fb.com> <20150520133614.3c4c460c@gandalf.local.home>
In-Reply-To: <20150520133614.3c4c460c@gandalf.local.home>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 989
Lines: 23

On 05/20/2015 01:36 PM, Steven Rostedt wrote:
> On Fri, 8 May 2015 15:29:01 -0400
> Josef Bacik <jbacik@fb.com> wrote:
>
>> With --merge we want to be able to merge the scheduling information as well so
>> we can see how the whole app spent its time.  This is a little tricky because we
>> have to sort based on comm instead of pid.  It works out well enough because we
>> store the intermediate information in the per task hash, but we want to group
>> the final information together.
>
> If we do the merge at the end, we wont need to worry about this.

Yeah that's true, I guess this is probably the best argument for doing 
it this way.  Ignore my last email, I'll go ahead and rework stuff to do 
the grouping at the end.  Thanks,

Josef

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/