Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636AbbETSWl (ORCPT ); Wed, 20 May 2015 14:22:41 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:46943 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753204AbbETSWk (ORCPT ); Wed, 20 May 2015 14:22:40 -0400 Message-ID: <555CD0E7.4040701@fb.com> Date: Wed, 20 May 2015 14:22:31 -0400 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steven Rostedt CC: , Subject: Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile References: <1431113344-22579-1-git-send-email-jbacik@fb.com> <1431113344-22579-4-git-send-email-jbacik@fb.com> <20150520140029.2078359f@gandalf.local.home> In-Reply-To: <20150520140029.2078359f@gandalf.local.home> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-05-20_05:2015-05-19,2015-05-20,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 44 On 05/20/2015 02:00 PM, Steven Rostedt wrote: > On Fri, 8 May 2015 15:29:02 -0400 > Josef Bacik wrote: > >> When we profile syscall times we're just given the syscall number, not the name. >> This isn't helpful for human beings, so lookup the syscall names when we are >> printing out the information. This uses the audit library to get this >> information, I'm not married to it, but it seems that any app that does this >> mapping has to scrape /usr/include/asm/unistd*.h to pull out the names, so might >> as well just use somebody elses work. >> >> Signed-off-by: Josef Bacik >> --- >> Makefile | 2 +- >> trace-profile.c | 19 ++++++++++++++++--- >> 2 files changed, 17 insertions(+), 4 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 63f7e79..402f711 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -160,7 +160,7 @@ bindir_relative_SQ = $(subst ','\'',$(bindir_relative)) >> plugin_dir_SQ = $(subst ','\'',$(plugin_dir)) >> python_dir_SQ = $(subst ','\'',$(python_dir)) >> >> -LIBS = -L. -ltracecmd -ldl >> +LIBS = -L. -ltracecmd -ldl -laudit > > This fails to compile for me because I don't have a audit-libs-devel > installed. > > I'll keep this as is, but I'm going to add code to check for this > library, and go back to the default raw numbers if it doesn't exist. > Maybe we should think about autoconf at some point? Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/