Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754201AbbETSuf (ORCPT ); Wed, 20 May 2015 14:50:35 -0400 Received: from www.linutronix.de ([62.245.132.108]:34572 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbbETSu3 (ORCPT ); Wed, 20 May 2015 14:50:29 -0400 Date: Wed, 20 May 2015 20:50:36 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, matt.fleming@intel.com, will.auld@intel.com, peter.zijlstra@intel.com, h.peter.anvin@intel.com, kanaka.d.juvva@intel.com, mtosatti@redhat.com Subject: Re: [PATCH 5/7] x86/intel_rdt: Software Cache for IA32_PQR_MSR In-Reply-To: Message-ID: References: <1431370976-31115-1-git-send-email-vikas.shivappa@linux.intel.com> <1431370976-31115-6-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 32 On Wed, 20 May 2015, Vikas Shivappa wrote: > On Fri, 15 May 2015, Thomas Gleixner wrote: > > > -static DEFINE_PER_CPU(struct intel_cqm_state, cqm_state); > > > +DEFINE_PER_CPU(struct intel_pqr_state, pqr_state); > > > > With CONFIG_PERF=n and CONFIG_CGROUP_RDT=y the linker will fail. > > copy from Makefile below - > obj-$(CONFIG_CPU_SUP_INTEL) += perf_event_intel_rapl.o > perf_event_intel_cqm.o > > should work with CONFIG_PERF_EVENTS=n and CGROUP_RDT=y ? Groan. Did you try to compile it? Certainly not. Simply because the whole section which contains perf_event* object files is conditional on ifdef CONFIG_PERF_EVENTS I'm starting to get really grumpy and tired of your attitude. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/