Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262AbbETTkp (ORCPT ); Wed, 20 May 2015 15:40:45 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:36169 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbbETTko (ORCPT ); Wed, 20 May 2015 15:40:44 -0400 Message-ID: <555CE339.2040205@lwfinger.net> Date: Wed, 20 May 2015 14:40:41 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jagan Teki , "linux-kernel@vger.kernel.org" CC: devel@driverdev.osuosl.org, Florian Schilhabel , Greg Kroah-Hartman , Dan Carpenter Subject: Re: [PATCH v3] staging: rtl8712: Use ether_addr_copy() instead of memcpy() References: <1431966765-10259-1-git-send-email-jteki@openedev.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2349 Lines: 63 On 05/20/2015 01:41 PM, Jagan Teki wrote: > On 18 May 2015 at 22:02, Jagan Teki wrote: >> Fixes Warning encounter this by applying checkpatch.pl against this file: >> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses >> are __aligned(2) >> >> pahole output for respective structures: >> - addr->sa_data >> struct sockaddr { >> sa_family_t sa_family; /* 0 2 */ >> char sa_data[14]; /* 2 14 */ >> >> /* size: 16, cachelines: 1, members: 2 */ >> /* last cacheline: 16 bytes */ >> }; >> >> - pnetdev->dev_addr >> dev_addr is interface address infor from generic net_device structure >> which is properly aligned and have some patches with this change as well. >> "staging: rtl8712: fix Prefer ether_addr_copy() over memcpy()" >> (sha1: 36e4d8826b317080e283e4edd08bf8d5ac706f38) >> >> Signed-off-by: Jagan Teki >> Cc: Greg Kroah-Hartman >> Cc: Larry Finger >> Cc: Florian Schilhabel >> --- >> Changes for v3: >> - Removed unaligned conversions >> Changes for v2: >> - Describe a changelog, to prove address are aligned >> >> drivers/staging/rtl8712/os_intfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c >> index 6e776e5..d5f4c4d 100644 >> --- a/drivers/staging/rtl8712/os_intfs.c >> +++ b/drivers/staging/rtl8712/os_intfs.c >> @@ -181,7 +181,7 @@ static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p) >> struct sockaddr *addr = p; >> >> if (padapter->bup == false) >> - memcpy(pnetdev->dev_addr, addr->sa_data, ETH_ALEN); >> + ether_addr_copy(pnetdev->dev_addr, addr->sa_data); >> return 0; >> } >> >> -- > > Ping! Ah. Not only are you ignorant, but you are also rude! The patch was not NACKed, thus it will be picked up in good time. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/