Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310AbbETTlo (ORCPT ); Wed, 20 May 2015 15:41:44 -0400 Received: from s159.web-hosting.com ([68.65.121.203]:60237 "EHLO s159.web-hosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbETTlm (ORCPT ); Wed, 20 May 2015 15:41:42 -0400 MIME-Version: 1.0 In-Reply-To: <555CDF0A.9080006@kernel.dk> References: <1431976472-27596-1-git-send-email-jteki@openedev.com> <555CDF0A.9080006@kernel.dk> Date: Thu, 21 May 2015 01:11:39 +0530 Message-ID: Subject: Re: [PATCH] block: Use BIT macro from include/linux/bitops.h From: Jagan Teki To: Jens Axboe Cc: "linux-kernel@vger.kernel.org" , Wolfram Sang Content-Type: text/plain; charset=UTF-8 X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server159.web-hosting.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - openedev.com X-Get-Message-Sender-Via: server159.web-hosting.com: authenticated_id: jteki@openedev.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 611 Lines: 20 On 21 May 2015 at 00:52, Jens Axboe wrote: > On 05/18/2015 01:14 PM, Jagan Teki wrote: >> >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31 > > > I don't like it, I think it hurts readability. What do you mean by don't like, using kernel defined macro instead of numerical assignments huts readability? thanks! -- Jagan Teki, Openedev. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/