Message-ID: <1432153459.20840.4.camel@perches.com>
Subject: Re: [PATCH 1/2] dma: omap-dma: Fix line over 80 characters
From: Joe Perches <joe@perches.com>
To: Jagan Teki <jteki@openedev.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vinod.koul@intel.com>
Date: Wed, 20 May 2015 13:24:19 -0700
In-Reply-To: <1432149070-9569-1-git-send-email-jteki@openedev.com>
References: <1432149070-9569-1-git-send-email-jteki@openedev.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1586
Lines: 45

On Thu, 2015-05-21 at 00:41 +0530, Jagan Teki wrote:
> This patch fixes line over 80 characters warninings while
> running checkpatch.pl

These changes aren't necessary.

If you're really going to do this, please change the style
of the functions you are using.

> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
[]
> @@ -168,7 +168,8 @@ static inline struct omap_chan *to_omap_dma_chan(struct dma_chan *c)
>  	return container_of(c, struct omap_nochan, vc.chan);
>  }
>  
> -static inline struct omap_desc *to_omap_dma_desc(struct dma_async_tx_descriptor *t)
> +static inline struct omap_desc *to_omap_dma_desc(
> +				struct dma_async_tx_descriptor *t)

This isn't particularly human readable.

If the return type is long, it's sometimes better to
use a separate line for the return type, then put the
function on another line like:

static inline struct omap_desc *
to_omap_dma_desc(struct dma_async_tx_descriptor *t)

> @@ -707,7 +710,8 @@ static enum dma_status omap_dma_tx_status(struct dma_chan *chan,
>  	spin_lock_irqsave(&c->vc.lock, flags);
>  	vd = vchan_find_desc(&c->vc, cookie);
>  	if (vd) {
> -		txstate->residue = omap_dma_desc_size(to_omap_dma_desc(&vd->tx));
> +		txstate->residue = omap_dma_desc_size(
> +						to_omap_dma_desc(&vd->tx));

This is unpleasant to read.
Just let some lines be > 80 columns.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/