Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754818AbbETXrr (ORCPT ); Wed, 20 May 2015 19:47:47 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18854 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753947AbbETXrp (ORCPT ); Wed, 20 May 2015 19:47:45 -0400 Message-ID: <555D1D16.9060205@oracle.com> Date: Thu, 21 May 2015 07:47:34 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Julien Grall , roger.pau@citrix.com CC: xen-devel@lists.xen.org, justing@spectralogic.com, paul.durrant@citrix.com, linux-kernel@vger.kernel.org, david.vrabel@citrix.com Subject: Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support References: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> <1432127422-6797-2-git-send-email-bob.liu@oracle.com> <555C8A3D.9010105@citrix.com> <555CA0B9.9050108@citrix.com> <555CA170.7070607@citrix.com> In-Reply-To: <555CA170.7070607@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 51 On 05/20/2015 11:00 PM, Julien Grall wrote: > On 20/05/15 15:56, Roger Pau Monn? wrote: >> El 20/05/15 a les 15.21, Julien Grall ha escrit: >>> Hi, >>> >>> On 20/05/15 14:10, Bob Liu wrote: >>>> --- >>>> drivers/block/xen-blkback/blkback.c | 12 ++++ >>>> drivers/block/xen-blkback/common.h | 3 +- >>>> drivers/block/xen-blkback/xenbus.c | 85 +++++++++++++++++++++------- >>>> drivers/block/xen-blkfront.c | 110 ++++++++++++++++++++++++++---------- >>>> 4 files changed, 161 insertions(+), 49 deletions(-) >>>> >>>> diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c >>>> index 713fc9f..057890f 100644 >>>> --- a/drivers/block/xen-blkback/blkback.c >>>> +++ b/drivers/block/xen-blkback/blkback.c >>>> @@ -84,6 +84,12 @@ MODULE_PARM_DESC(max_persistent_grants, >>>> "Maximum number of grants to map persistently"); >>>> >>>> /* >>>> + * Maximum number of pages to be used as the ring between front and backend >>>> + */ >>>> +unsigned int xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER; >>> >>> We will soon support 64KB page granularity with ARM64, although the PV >>> protocol will keep a 4KB page granularity. >>> >>> Can you clarify with granularity is used here? The one of the host or >>> the one of the PV protocol? >> >> It's using 4K pages, because those are then granted to the domain >> handling the backend. > > It would be nice to add a word in the comment. > Sure, I'll make a update. Roger, can I get your ack of these two patches except this comment update? -- Regards, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/