Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754544AbbETXy7 (ORCPT ); Wed, 20 May 2015 19:54:59 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33549 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbbETXy4 (ORCPT ); Wed, 20 May 2015 19:54:56 -0400 Date: Wed, 20 May 2015 16:54:47 -0700 From: Brian Norris To: Marek Vasut Cc: Michal Suchanek , Thomas.Betker@rohde-schwarz.com, Alison Chaiken , Huang Shijie , "Bean Huo ????????? (beanhuo)" , Ben Hutchings , devicetree , David Woodhouse , Kumar Gala , "grmoore@altera.com" , Ian Campbell , Linux Kernel Mailing List , linux-mtd@lists.infradead.org, linux-mtd , linux-sunxi , Mark Rutland , Mika Westerberg , Pawel Moll , Rob Herring , Rafa?? Mi??ecki , linux-spi@vger.kernel.org, Mark Brown Subject: Re: [PATCH 0/3] Using SPI NOR flah on sunxi. Message-ID: <20150520235447.GZ11598@ld-irv-0074> References: <201504302034.36753.marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201504302034.36753.marex@denx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 35 On Thu, Apr 30, 2015 at 08:34:36PM +0200, Marek Vasut wrote: > On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote: > > On 30 April 2015 at 18:30, wrote: > > > Hello Michal: > > >> I tried to connect a SPI NOR flash to my sunxi board and due to the > > > > > > current > > > > > >> sunxi SPI driver limitations it does not work. > > >> > > >> The SPI driver returns an error when more than 64 bytes are > > >> transferred at once > > >> due to lack of DMA support. > > > > > > Wouldn't it be easier to fix the SPI driver to handle transfers larger > > > than 64 bytes, filling and draining the FIFO multiple times if > > > neccessary? (As far as I can tell, most SPI drivers do this.) > > > > Yes, the intent is to fix this by adding dma support to the driver, > > eventually. > > > > The patch might be still useful for other hardware with developing SPI > > support. > > Please just fix the controller driver to correctly handle arbitrary transfer > lengths. Just noticed this. Yes, that would definitely be a better option! Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/