Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132AbbEUDsG (ORCPT ); Wed, 20 May 2015 23:48:06 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:36638 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbbEUDsD (ORCPT ); Wed, 20 May 2015 23:48:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150521031334.GA2897@shlinux2> References: <1432087805-16671-1-git-send-email-robh@kernel.org> <1432087805-16671-7-git-send-email-robh@kernel.org> <20150521031334.GA2897@shlinux2> From: Rob Herring Date: Wed, 20 May 2015 22:47:42 -0500 X-Google-Sender-Auth: LtXQj-XCAw65ZkDx8hEfSOglqOw Message-ID: Subject: Re: [PATCH v2 6/6] usb: chipidea: add work-around for Marvell HSIC PHY startup To: Peter Chen Cc: Greg Kroah-Hartman , Kishon Vijay Abraham I , Linux USB List , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Arnd Bergmann , Alan Stern Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 21 On Wed, May 20, 2015 at 10:13 PM, Peter Chen wrote: > On Tue, May 19, 2015 at 09:10:05PM -0500, Rob Herring wrote: >> The Marvell 28nm HSIC PHY requires the port to be forced to HS mode after >> the port power is applied. This is done using the test mode in the PORTSC >> register. >> >> As HSIC is always HS, this work-around should be safe to do with all HSIC >> PHYs. If not, a flag can also be added. > > I think a flag is needed, not sure all vendors can work well with that. Only i.MX6Sx uses HSIC in mainline. Is that something you can test? It would be better to not add flags unless they are really needed. Otherwise you end up with dozens of flags like SDHCI drivers have. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/