Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753731AbbEUGSo (ORCPT ); Thu, 21 May 2015 02:18:44 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:33844 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbbEUGSl (ORCPT ); Thu, 21 May 2015 02:18:41 -0400 Date: Thu, 21 May 2015 08:18:37 +0200 From: Ingo Molnar To: John Stultz Cc: LKML , Badhri Jagan Sridharan , Thomas Gleixner Subject: Re: [PATCH 4/7] tracing: timer: Add deferrable flag to timer_start Message-ID: <20150521061837.GB11077@gmail.com> References: <1432142376-2077-1-git-send-email-john.stultz@linaro.org> <1432142376-2077-5-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432142376-2077-5-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1657 Lines: 58 * John Stultz wrote: > From: Badhri Jagan Sridharan > > The timer_start event now shows whether the timer is > deferrable in case of a low-res timer. The debug_activate > function now includes deferrable flag while calling > trace_timer_start event. s/now includes deferrable flag/ now includes a deferrable flag s/calling trace_timer_start event/ calling the trace_timer_start event > TRACE_EVENT(timer_start, > > - TP_PROTO(struct timer_list *timer, unsigned long expires), > + TP_PROTO(struct timer_list *timer, > + unsigned long expires, This isn't compat safe, should any tooling rely on this. I see it's a mistake in prior code: > + unsigned int deferrable), > > - TP_ARGS(timer, expires), > + TP_ARGS(timer, expires, deferrable), > > TP_STRUCT__entry( > __field( void *, timer ) > __field( void *, function ) > __field( unsigned long, expires ) > __field( unsigned long, now ) which should probably be fixed as well. > @@ -650,7 +650,8 @@ static inline void > debug_activate(struct timer_list *timer, unsigned long expires) > { > debug_timer_activate(timer); > - trace_timer_start(timer, expires); > + trace_timer_start(timer, expires, > + tbase_get_deferrable(timer->base)); why is this line broken? If you put it into a single line it's still below 80 cols, so there's really no reason for it. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/