Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754391AbbEUGXN (ORCPT ); Thu, 21 May 2015 02:23:13 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37879 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbbEUGXL (ORCPT ); Thu, 21 May 2015 02:23:11 -0400 Date: Thu, 21 May 2015 08:23:04 +0200 From: Ingo Molnar To: John Stultz Cc: LKML , Xunlei Pang , Thomas Gleixner , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com Subject: Re: [PATCH 6/7] s390: time: Provide read_boot_clock64() and read_persistent_clock64() Message-ID: <20150521062304.GE11077@gmail.com> References: <1432142376-2077-1-git-send-email-john.stultz@linaro.org> <1432142376-2077-7-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432142376-2077-7-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 50 * John Stultz wrote: > From: Xunlei Pang > > As part of addressing "y2038 problem" for in-kernel uses, this > patch converts read_boot_clock() to read_boot_clock64() and > read_persistent_clock() to read_persistent_clock64() using > timespec64. s/addressing "y2037 problem"/ addressing the "y2037 problem" > Rename some timespec to timespec64 in time.c and related references. This sentence does not parse. Did you want to say: Rename some instances of 'timespec' to 'timespec64' in time.c and related references. ? > @@ -108,10 +109,10 @@ int get_sync_clock(unsigned long long *clock); > void init_cpu_timer(void); > unsigned long long monotonic_clock(void); > > -void tod_to_timeval(__u64, struct timespec *); > +void tod_to_timeval(__u64, struct timespec64 *); Please use proper prototypes with parameters spelled out as well, so that people grepping for APIs don't have to guess too much. > - rc += sprintf(out_buf, "%02i %011lu:%06lu %1u %1s %02i %p ", > - area, time_spec.tv_sec, time_spec.tv_nsec / 1000, level, > - except_str, entry->id.fields.cpuid, (void *) caller); > + rc += sprintf(out_buf, "%02i %011lld:%06lu %1u %1s %02i %p ", > + area, (long long) time_spec.tv_sec, > + time_spec.tv_nsec / 1000, level, except_str, > + entry->id.fields.cpuid, (void *) caller); Unnecessary space before the casts. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/