Message-ID: <1432194094.21715.113.camel@x220>
Subject: Re: [PATCH 2/5] phy: iproc-mdio: Initial iProc MDC/MDIO support
From: Paul Bolle <pebolle@tiscali.nl>
To: Ray Jui <rjui@broadcom.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org,
        "JD (Jiandong) Zheng" <jdzheng@broadcom.com>,
        Arun Parameswaran <arunp@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Date: Thu, 21 May 2015 09:41:34 +0200
In-Reply-To: <1432085014-20758-3-git-send-email-rjui@broadcom.com>
References: <1432085014-20758-1-git-send-email-rjui@broadcom.com>
	 <1432085014-20758-3-git-send-email-rjui@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 50

On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote:
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
>  
> +config PHY_IPROC_MDIO
> +	bool "Broadcom iProc MDC/MDIO driver"
> +	depends on ARCH_BCM_IPROC
> +	default ARCH_BCM_IPROC
> +	help
> +	  Enable this to support the iProc generic MDC/MDIO interface found
> +	  in various iProc based SoCs. The generic MDC/MDIO interface can be
> +	  used to communicate with various types of Serdes/PHYs including
> +	  Ethernet, PCIe, USB, and etc.
> +
> +	  If unsure, say N.

> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile

> +obj-$(CONFIG_PHY_IPROC_MDIO)		+= phy-iproc-mdio.o

> --- /dev/null
> +++ b/drivers/phy/phy-iproc-mdio.c

> +#include <linux/module.h>

> +static int __init iproc_mdio_init(void)
> +{
> +	return platform_driver_register(&iproc_mdio_driver);
> +}
> +arch_initcall_sync(iproc_mdio_init);
> +
> +MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>");
> +MODULE_DESCRIPTION("Broadcom iPROC MDC/MDIO driver");
> +MODULE_LICENSE("GPL v2");

I guess phy-iproc-mdio.o is intended to be built-in only. If that's
correct the above three MODULE_ macros (and, probably, the include of
linux/module.h) can safely be dropped.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/