Message-ID: <1432194775.21715.118.camel@x220>
Subject: Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support
From: Paul Bolle <pebolle@tiscali.nl>
To: Ray Jui <rjui@broadcom.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org,
        "JD (Jiandong) Zheng" <jdzheng@broadcom.com>,
        Arun Parameswaran <arunp@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Date: Thu, 21 May 2015 09:52:55 +0200
In-Reply-To: <1432085014-20758-5-git-send-email-rjui@broadcom.com>
References: <1432085014-20758-1-git-send-email-rjui@broadcom.com>
	 <1432085014-20758-5-git-send-email-rjui@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1672
Lines: 62

On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote:
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
 
> +config PHY_CYGNUS_PCIE
> +	bool "Broadcom Cygnus PCIe PHY driver"
> +	depends on ARCH_BCM_CYGNUS
> +	select GENERIC_PHY
> +	select PHY_IPROC_MDIO
> +	default ARCH_BCM_CYGNUS
> +	help
> +	  Enable this to support the Broadcom Cygnus PCIe PHY.
> +
> +	  The host communicates with the PHY through the iProc MDC/MDIO
> +	  interface.
> +
> +	  If unsure, say N.
> +
> +

> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile

> +obj-$(CONFIG_PHY_CYGNUS_PCIE)		+= phy-cygnus-pcie.o

> --- /dev/null
> +++ b/drivers/phy/phy-cygnus-pcie.c

> +#include <linux/module.h>

> +static const struct of_device_id cygnus_pcie_phy_match_table[] = {
> +	{ .compatible = "brcm,cygnus-pcie-phy" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, cygnus_pcie_phy_match_table);
> +
> +static struct platform_driver cygnus_pcie_phy_driver = {
> +	.driver = {
> +		.name		= "cygnus-pcie-phy",
> +		.of_match_table	= cygnus_pcie_phy_match_table,
> +	},
> +	.probe	= cygnus_pcie_phy_probe,
> +};
> +module_platform_driver(cygnus_pcie_phy_driver);
> +
> +MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>");
> +MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver");
> +MODULE_LICENSE("GPL v2");

And here I guess you intend this to be buildable as a module. If that's
the intention I think PHY_CYGNUS_PCIE needs to be tristate.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/