Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbbEUIJx (ORCPT ); Thu, 21 May 2015 04:09:53 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:34090 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbbEUIJr (ORCPT ); Thu, 21 May 2015 04:09:47 -0400 Message-ID: <1432195782.21715.123.camel@x220> Subject: Re: [PATCH 1/5] soc: mediatek: Add infracfg misc driver support From: Paul Bolle To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger Date: Thu, 21 May 2015 10:09:42 +0200 In-Reply-To: <1432131540-2523-2-git-send-email-s.hauer@pengutronix.de> References: <1432131540-2523-1-git-send-email-s.hauer@pengutronix.de> <1432131540-2523-2-git-send-email-s.hauer@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 46 Just a nit: an unneeded macro. On Wed, 2015-05-20 at 16:18 +0200, Sascha Hauer wrote: > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > +config MTK_INFRACFG > + bool "MediaTek INFRACFG Support" > + depends on ARCH_MEDIATEK > + select REGMAP > + help > + Say yes here to add support for the MediaTek INFRACFG controller. The > + INFRACFG controller contains various infrastructure registers not > + directly associated to any device. > + > --- a/drivers/soc/mediatek/Makefile > +++ b/drivers/soc/mediatek/Makefile > +obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > --- /dev/null > +++ b/drivers/soc/mediatek/mtk-infracfg.c > +#include > +MODULE_LICENSE("GPL v2"); MTK_INFRACFG was changed from tristate to bool in this version. Note that for built-in code MODULE_LICENSE() will be effectively preprocessed away. So you can drop that macro, and the include of linux/module.h too. (I did a quick compile to see if nothing else requires module.h, and it compiled cleanly without that include.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/