Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755239AbbEUIWe (ORCPT ); Thu, 21 May 2015 04:22:34 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:43881 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbbEUIWL (ORCPT ); Thu, 21 May 2015 04:22:11 -0400 Message-ID: <1432196527.21715.130.camel@x220> Subject: Re: [PATCH 3/5] soc: Mediatek: Add SCPSYS power domain driver From: Paul Bolle To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger Date: Thu, 21 May 2015 10:22:07 +0200 In-Reply-To: <1432131540-2523-4-git-send-email-s.hauer@pengutronix.de> References: <1432131540-2523-1-git-send-email-s.hauer@pengutronix.de> <1432131540-2523-4-git-send-email-s.hauer@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 52 On Wed, 2015-05-20 at 16:18 +0200, Sascha Hauer wrote: > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > +config MTK_SCPSYS > + bool "MediaTek SCPSYS Support" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + select REGMAP > + select MTK_INFRACFG > + help > + Say yes here to add support for the MediaTek SCPSYS power domain > + driver. > +obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o > --- /dev/null > +++ b/drivers/soc/mediatek/mtk-scpsys.c > +#include > +MODULE_DEVICE_TABLE(of, of_scpsys_match_tbl); > + > +static struct platform_driver scpsys_drv = { > + .owner = THIS_MODULE, > +}; > + > +module_platform_driver_probe(scpsys_drv, scpsys_probe); (A patch was recently submitted that would allow built-in only code to use builtin_platform_driver_probe(), see https://lkml.org/lkml/2015/5/10/125 .) > +MODULE_AUTHOR("Sascha Hauer, Pengutronix"); > +MODULE_DESCRIPTION("MediaTek MT8173 scpsys driver"); > +MODULE_LICENSE("GPL v2"); MTK_SCPSYS was changed from tristate to bool in this version. As mtk-scpsys.o can now only be built-in I think the above module specific macros can safely be dropped. Probably ditto for the module.h include. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/