Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305AbbEUKwX (ORCPT ); Thu, 21 May 2015 06:52:23 -0400 Received: from smtp.citrix.com ([66.165.176.89]:24831 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbbEUKwT (ORCPT ); Thu, 21 May 2015 06:52:19 -0400 X-IronPort-AV: E=Sophos;i="5.13,468,1427760000"; d="scan'208";a="264741597" Message-ID: <555DB8DD.2080000@citrix.com> Date: Thu, 21 May 2015 12:52:13 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu , CC: , , , , Subject: Re: [PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place References: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> In-Reply-To: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1881 Lines: 45 El 20/05/15 a les 15.10, Bob Liu ha escrit: > The major responsibility of talk_to_blkback() is allocate and initialize the > request ring and writes the ring info stuff out. ^ write ^ to xenstore. > But this work should be done after backend entered 'XenbusStateInitWait' as > defined in the protocol file. > See xen/include/public/io/blkif.h in XEN git tree: > Front Back > ================================= ===================================== > XenbusStateInitialising XenbusStateInitialising > o Query virtual device o Query backend device identification > properties. data. > o Setup OS device instance. o Open and validate backend device. > o Publish backend features and > transport parameters. > | > | > V > XenbusStateInitWait > > o Query backend features and > transport parameters. > o Allocate and initialize the > request ring. > > There is no problem with this yet, but it is an violation of the design and > furthermore it would not allow frontend/backend to negotiate 'multi-page' and > 'multi-queue' features. > > Changes in v2: > - Re-write the commit message to be more clear. > > Signed-off-by: Bob Liu With that fixed: Acked-by: Roger Pau Monn? Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/