Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754818AbbEULMq (ORCPT ); Thu, 21 May 2015 07:12:46 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38140 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbEULMp (ORCPT ); Thu, 21 May 2015 07:12:45 -0400 Date: Thu, 21 May 2015 12:12:38 +0100 From: Al Viro To: Maninder Singh Cc: akpm@linux-foundation.org, dhowells@redhat.com, fabf@skynet.be, linux-kernel@vger.kernel.org, "v.narang@samsung.com" Subject: Re: [EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL dereference Message-ID: <20150521111238.GB7232@ZenIV.linux.org.uk> References: <1817342376.533191432204130151.JavaMail.weblogic@ep2mlwas07b> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1817342376.533191432204130151.JavaMail.weblogic@ep2mlwas07b> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 18 On Thu, May 21, 2015 at 10:28:52AM +0000, Maninder Singh wrote: > Subject: [PATCH 1/1] devpts/inode.c : Fix Possible dentry NULL dereference > > Issue reported by static tool Analyzer (Prevent). > d_find_alias can return NULL to deentry, Thus we need NULL check > before calling d_delete(dentry) No, we do not. That inode must have come from devpts_pty_new() and it wouldn't have made it out of there without having a dentry attached to it (and pinned). NAK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/