From: "Hubbe, Allen" <Allen.Hubbe@emc.com>
To: Paul Bolle <pebolle@tiscali.nl>
CC: "linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>
Subject: RE: [PATCH 02/16] NTB Abstraction Layer
Thread-Topic: [PATCH 02/16] NTB Abstraction Layer
Thread-Index: AQHQkz1jcCwwR12uTEGLA3+Bagb+f52GY1sA///f/AA=
Date: Thu, 21 May 2015 11:32:26 +0000
Message-ID: <40F65EF2B5E2254199711F58E3ACB84D7825F98C@MX104CL02.corp.emc.com>
References: <cover.1432135631.git.Allen.Hubbe@emc.com>
	 <d653819e0ebc03241fe073c9239be36a52f5e265.1432135631.git.Allen.Hubbe@emc.com>
 <1432198316.21715.135.camel@x220>
In-Reply-To: <1432198316.21715.135.camel@x220>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1829
Lines: 73

From: Paul Bolle [mailto:pebolle@tiscali.nl]
> On Wed, 2015-05-20 at 11:41 -0400, Allen Hubbe wrote:


> 
> (My mailer tells me this message is over 200KB in size. Did you consider
> offering bribes to get people to review this patch?)

I would have liked to send smaller patches, too.

I attempted to split this one in three:
1) add the ntb core driver and header file
2) change ntb_hw_intel driver to use new api
3) change ntb_transport driver to use new api

The problem is, any change to the old ntb_hw_intel (was ntb.ko), or ntb_transport, alone will cause the other not to work.

> 
> I just spotted two nits.
> 
> > --- a/drivers/ntb/Kconfig
> > +++ b/drivers/ntb/Kconfig
> >
> > +if NTB
> > +
> > +source "drivers/ntb/hw/Kconfig"
> > +
> > +config NTB_TRANSPORT
> > +       tristate "NTB Transport Client"
> > +       depends on NTB
> 
> Superfluous dependency.

I will remove depends NTB from this, and other things within if NTB.

I will also change the leading spaces to tabs.

> 
> > +       help
> > +        This is a transport driver that enables connected systems to
> exchange
> > +        messages over the ntb hardware.  The transport exposes a
> queue pair api
> > +        to client drivers.
> > +
> > +        If unsure, say N.
> > +
> > +endif # NTB
> 
> > --- /dev/null
> > +++ b/drivers/ntb/hw/intel/Kconfig
> 
> > +config NTB_INTEL
> > +       tristate "Intel Non-Transparent Bridge support"
> > +       depends on NTB
> 
> Ditto.
> 
> > +       depends on X86
> > +       help
> > +        This driver supports Intel NTB on capable Xeon and Atom
> hardware.
> > +
> > +        If unsure, say N.
> 
> Thanks,
> 
> 
> Paul Bolle

Thanks,
Allen
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?