Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755571AbbEUNUX (ORCPT ); Thu, 21 May 2015 09:20:23 -0400 Received: from casper.infradead.org ([85.118.1.10]:41670 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbbEUNUU (ORCPT ); Thu, 21 May 2015 09:20:20 -0400 Date: Thu, 21 May 2015 15:20:15 +0200 From: Peter Zijlstra To: Stephane Eranian Cc: Ingo Molnar , Vince Weaver , Jiri Olsa , "Liang, Kan" , LKML , Andrew Hunter , Maria Dimakopoulou Subject: Re: [PATCH 01/10] perf,x86: Fix event/group validation Message-ID: <20150521132015.GS3644@twins.programming.kicks-ass.net> References: <20150521111710.475482798@infradead.org> <20150521111932.592505273@infradead.org> <20150521125615.GO3644@twins.programming.kicks-ass.net> <20150521130952.GQ3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 13 On Thu, May 21, 2015 at 06:18:15AM -0700, Stephane Eranian wrote: > Yes, it does modify the cpuc->event_list[]->hwc, because it is used as a > cache for *EACH* invocation of the function. It is irrelevant outside the > function. Yes, but the problem is that they _nest_. So you get to use the one from the nested call in the outer call. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/