Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756212AbbEUN1Z (ORCPT ); Thu, 21 May 2015 09:27:25 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:33508 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755945AbbEUN1S (ORCPT ); Thu, 21 May 2015 09:27:18 -0400 MIME-Version: 1.0 In-Reply-To: <20150521132015.GS3644@twins.programming.kicks-ass.net> References: <20150521111710.475482798@infradead.org> <20150521111932.592505273@infradead.org> <20150521125615.GO3644@twins.programming.kicks-ass.net> <20150521130952.GQ3644@twins.programming.kicks-ass.net> <20150521132015.GS3644@twins.programming.kicks-ass.net> Date: Thu, 21 May 2015 06:27:17 -0700 Message-ID: Subject: Re: [PATCH 01/10] perf,x86: Fix event/group validation From: Stephane Eranian To: Peter Zijlstra Cc: Ingo Molnar , Vince Weaver , Jiri Olsa , "Liang, Kan" , LKML , Andrew Hunter , Maria Dimakopoulou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 17 On Thu, May 21, 2015 at 6:20 AM, Peter Zijlstra wrote: > On Thu, May 21, 2015 at 06:18:15AM -0700, Stephane Eranian wrote: >> Yes, it does modify the cpuc->event_list[]->hwc, because it is used as a >> cache for *EACH* invocation of the function. It is irrelevant outside the >> function. > > Yes, but the problem is that they _nest_. > > So you get to use the one from the nested call in the outer call. You mean x86_schedule_events() calls x86_schedule_events()? Or are you talking about a preemption while executing x86_schedule_events()? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/