Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756702AbbEUNdZ (ORCPT ); Thu, 21 May 2015 09:33:25 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:56455 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755701AbbEUNdO (ORCPT ); Thu, 21 May 2015 09:33:14 -0400 X-IronPort-AV: E=Sophos;i="5.13,469,1427760000"; d="scan'208";a="267293344" Message-ID: <555DDE94.3030005@citrix.com> Date: Thu, 21 May 2015 15:33:08 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu CC: , , , , , Subject: Re: [PATCH v4 2/2] xen/block: add multi-page ring support References: <1432127422-6797-1-git-send-email-bob.liu@oracle.com> <1432127422-6797-2-git-send-email-bob.liu@oracle.com> <555DBFE9.7050701@citrix.com> <555DD790.3040302@oracle.com> In-Reply-To: <555DD790.3040302@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 44 El 21/05/15 a les 15.03, Bob Liu ha escrit: > On 05/21/2015 07:22 PM, Roger Pau Monn? wrote: >> El 20/05/15 a les 15.10, Bob Liu ha escrit: >>> + err = xenbus_scanf(XBT_NIL, dev->otherend, >>> + ring_ref_name, "%u", &ring_ref[i]); >> >> No need to split lines unless they are > 100 chars (here and elsewhere). >> > > Not 82 chars? Sorry, I must be utterly confused, line length should be 80. Forge about that comment. >>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c >>> index 88e23fd..3d1c6fb 100644 >>> --- a/drivers/block/xen-blkfront.c >>> +++ b/drivers/block/xen-blkfront.c >>> @@ -98,7 +98,17 @@ static unsigned int xen_blkif_max_segments = 32; >>> module_param_named(max, xen_blkif_max_segments, int, S_IRUGO); >>> MODULE_PARM_DESC(max, "Maximum amount of segments in indirect requests (default is 32)"); >>> >>> -#define BLK_RING_SIZE __CONST_RING_SIZE(blkif, PAGE_SIZE) >>> +static unsigned int xen_blkif_max_ring_order; >>> +module_param_named(max_ring_page_order, xen_blkif_max_ring_order, int, S_IRUGO); >>> +MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used as the ring"); >>> + >>> +#define BLK_RING_SIZE __CONST_RING_SIZE(blkif, PAGE_SIZE * info->nr_ring_pages) >> >> Didn't we agreed that this macro should take a explicit info parameter? >> > > Do you mean define like this? > #define BLK_RING_SIZE(info) __CONST_RING_SIZE(blkif, PAGE_SIZE * info->nr_ring_pages) Yes, something like that, but please add parentheses around info, so it looks like (info)->nr_ring_pages. Thanks, Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/