Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755852AbbEUOEN (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 May 2015 10:04:13 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:48408 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755756AbbEUOEL convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 May 2015 10:04:11 -0400
Message-ID: <1432217038.30671.7.camel@twins>
Subject: Re: [PATCH 01/10] perf,x86: Fix event/group validation
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Ingo Molnar <mingo@kernel.org>, Vince Weaver <vincent.weaver@maine.edu>,
        Jiri Olsa <jolsa@redhat.com>, "Liang, Kan" <kan.liang@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, Andrew Hunter <ahh@google.com>,
        Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
Date: Thu, 21 May 2015 16:03:58 +0200
In-Reply-To: <CABPqkBSeLqMeGwcnaj2yss3dAY_0naQjTCWsjREFaV-h0WzWKQ@mail.gmail.com>
References: <20150521111710.475482798@infradead.org>
	 <20150521111932.592505273@infradead.org>
	 <CABPqkBTrp8fyUobwWq2bZ_9Rg92nCX2xE3BHqDgW6FErP_waZQ@mail.gmail.com>
	 <20150521125615.GO3644@twins.programming.kicks-ass.net>
	 <CABPqkBTFPRwHX8zKERYFrMBVQor5GJcDd4ZcKt8WL-tjbJdzLw@mail.gmail.com>
	 <20150521130952.GQ3644@twins.programming.kicks-ass.net>
	 <CABPqkBRbK-SNAJS8_GDWDzc5V74WV5VjECzMkuuWFSjcE5spxQ@mail.gmail.com>
	 <20150521132015.GS3644@twins.programming.kicks-ass.net>
	 <CABPqkBTvAd3RAp2AuM6DUMk4-dKs6cAXOt-Ewfw58DodmTtU4Q@mail.gmail.com>
	 <1432214957.30671.0.camel@twins>
	 <CABPqkBSeLqMeGwcnaj2yss3dAY_0naQjTCWsjREFaV-h0WzWKQ@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2106
Lines: 58

On Thu, 2015-05-21 at 06:36 -0700, Stephane Eranian wrote:
> On Thu, May 21, 2015 at 6:29 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Thu, 2015-05-21 at 06:27 -0700, Stephane Eranian wrote:
> >> Or are you talking about a preemption while executing x86_schedule_events()?
> >
> > That.
> >
> > And we can of course cure that by an earlier patch I send; but I find it
> > a much simpler rule to just never allow modifying global state for
> > validation.
> 
> I can see  validation being preempted, but not the context switch code path.
> Is that what you are talking about?
> 
> You are saying validate_group() is in the middle of x86_schedule_events()
> using fake_cpuc, when it gets preempted. The context switch code when it loads
> the new thread's PMU state calls x86_schedule_events() which modifies the
> cpuc->event_list[]->hwc. But this is cpuc vs. fake_cpuc again. So yes, the calls
> nest but they do not touch the same state.

They both touch event->hw->constraint.

>  And when you eventually come back
> to validate_group() you are back to using the fake_cpuc. So I am still not clear
> on how the corruption can happen.

validate_group()
  x86_schedule_events()
    event->hw.constraint = c; # store

     <context switch>
       perf_task_event_sched_in()
         ...
           x86_schedule_events();
             event->hw.constraint = c2; # store

             ...

             put_event_constraints(event); # assume failure to schedule
               intel_put_event_constraints()
                 event->hw.constraint = NULL;

      <context switch end>

    c = event->hw.constraint; # read -> NULL

    if (!test_bit(hwc->idx, c->idxmsk)) # <- *BOOM* NULL deref


This in particular is possible when the event in question is a cpu-wide
event and group-leader, where the validate_group() tries to add an event
to the group.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/