Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755652AbbEUOcJ (ORCPT ); Thu, 21 May 2015 10:32:09 -0400 Received: from conssluserg002.nifty.com ([202.248.44.40]:51135 "EHLO conssluserg002-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755501AbbEUOcH convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 10:32:07 -0400 X-Greylist: delayed 107539 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 May 2015 10:32:07 EDT X-Nifty-SrcIP: [209.85.212.169] MIME-Version: 1.0 In-Reply-To: <20150520142358.GS31550@xsjsorenbubuntu> References: <1432111351-21336-1-git-send-email-yamada.masahiro@socionext.com> <20150520142358.GS31550@xsjsorenbubuntu> Date: Thu, 21 May 2015 23:31:54 +0900 Message-ID: Subject: Re: [RESEND PATCH 0/2] pinctrl: zynq: fix two bugs of zynq pinmux function From: Masahiro Yamada To: =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Linus Walleij Cc: linux-gpio@vger.kernel.org, Michal Simek , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 52 Hi Sören, 2015-05-20 23:23 GMT+09:00 Sören Brinkmann : > Hi Masahiro, > > On Wed, 2015-05-20 at 05:42PM +0900, Masahiro Yamada wrote: >> >> I sent the previous one to linux-serial by mistake. >> I am resending to linux-gpio, dropping linux-serial. >> Sorry for noise. >> >> >> >> Masahiro Yamada (2): >> pinctrl: zynq: fix DEFINE_ZYNQ_PINMUX_FUNCTION_MUX macro >> pinctrl: zynq: fix offset address for {SD0,SD1}_WP_CD_SEL > > For the series: > Reviewed-by: Sören Brinkmann > > I'm not sure how severe the impact of these bugs is. It looks like the > the current driver could corrupt the register for MIO pin0, am I right? Right. DEFINE_ZYNQ_PINMUX_FUNCTION_MUX() is missing the .mux so it is always set to zero, i.e. MIO pin0 register is corrupted. > It may be a good ides to add > Fixes: add958cee967 "pinctrl: Add driver for Zynq" > (I suspect that bug is there from the beginning) and ask Linus to > consider this for stable. Yes, looks like these two bugs have been there since the introduction of this driver. For the series, Fixes: add958cee967 (pinctrl: Add driver for Zynq) Linus, Could you consider this series for stable and linux-4.1, please? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/