Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102AbbEUOuG (ORCPT ); Thu, 21 May 2015 10:50:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44205 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754017AbbEUOuD (ORCPT ); Thu, 21 May 2015 10:50:03 -0400 Date: Thu, 21 May 2015 16:49:59 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com Subject: Re: [PATCH 06/12] KVM: x86: API changes for SMM support Message-ID: <20150521144954.GA10453@potion.brq.redhat.com> References: <1431084034-8425-1-git-send-email-pbonzini@redhat.com> <1431084034-8425-7-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431084034-8425-7-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 622 Lines: 16 2015-05-08 13:20+0200, Paolo Bonzini: > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > @@ -202,7 +202,7 @@ struct kvm_run { > __u32 exit_reason; > __u8 ready_for_interrupt_injection; > __u8 if_flag; > - __u8 padding2[2]; > + __u16 flags; (It got lost last review and I'd really like to know ... what is the advantage of giving both bytes to flags?) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/