Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932231AbbEUOxl (ORCPT ); Thu, 21 May 2015 10:53:41 -0400 Received: from casper.infradead.org ([85.118.1.10]:42214 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755393AbbEUOxi (ORCPT ); Thu, 21 May 2015 10:53:38 -0400 Date: Thu, 21 May 2015 16:53:31 +0200 From: Peter Zijlstra To: mingo@kernel.org Cc: vincent.weaver@maine.edu, eranian@google.com, jolsa@redhat.com, kan.liang@intel.com, linux-kernel@vger.kernel.org, Andrew Hunter , Maria Dimakopoulou Subject: Re: [PATCH 01/10] perf,x86: Fix event/group validation Message-ID: <20150521145331.GV3644@twins.programming.kicks-ass.net> References: <20150521111710.475482798@infradead.org> <20150521111932.592505273@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150521111932.592505273@infradead.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 22 On Thu, May 21, 2015 at 01:17:11PM +0200, Peter Zijlstra wrote: > --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c > +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c > @@ -706,9 +706,9 @@ void intel_pmu_pebs_disable(struct perf_ > > cpuc->pebs_enabled &= ~(1ULL << hwc->idx); > > - if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_LDLAT) > + if (event->hw.flags & PERF_X86_EVENT_PEBS_LDLAT) > cpuc->pebs_enabled &= ~(1ULL << (hwc->idx + 32)); > - else if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_ST) > + else if (event->hw.flags & PERF_X86_EVENT_PEBS_ST) > cpuc->pebs_enabled &= ~(1ULL << 63); > > if (cpuc->enabled) This btw look like an independent bug. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/