Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755424AbbEUPmH (ORCPT ); Thu, 21 May 2015 11:42:07 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:34209 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbbEUPmD (ORCPT ); Thu, 21 May 2015 11:42:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150521145331.GV3644@twins.programming.kicks-ass.net> References: <20150521111710.475482798@infradead.org> <20150521111932.592505273@infradead.org> <20150521145331.GV3644@twins.programming.kicks-ass.net> Date: Thu, 21 May 2015 08:42:02 -0700 Message-ID: Subject: Re: [PATCH 01/10] perf,x86: Fix event/group validation From: Stephane Eranian To: Peter Zijlstra Cc: Ingo Molnar , Vince Weaver , Jiri Olsa , "Liang, Kan" , LKML , Andrew Hunter , Maria Dimakopoulou Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 25 On Thu, May 21, 2015 at 7:53 AM, Peter Zijlstra wrote: > On Thu, May 21, 2015 at 01:17:11PM +0200, Peter Zijlstra wrote: >> --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c >> +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c >> @@ -706,9 +706,9 @@ void intel_pmu_pebs_disable(struct perf_ >> >> cpuc->pebs_enabled &= ~(1ULL << hwc->idx); >> >> - if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_LDLAT) >> + if (event->hw.flags & PERF_X86_EVENT_PEBS_LDLAT) >> cpuc->pebs_enabled &= ~(1ULL << (hwc->idx + 32)); >> - else if (event->hw.constraint->flags & PERF_X86_EVENT_PEBS_ST) >> + else if (event->hw.flags & PERF_X86_EVENT_PEBS_ST) >> cpuc->pebs_enabled &= ~(1ULL << 63); >> >> if (cpuc->enabled) > > This btw look like an independent bug. You mean, referring to event->hw.constraint? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/