Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756584AbbEUPu2 (ORCPT ); Thu, 21 May 2015 11:50:28 -0400 Received: from mga14.intel.com ([192.55.52.115]:11968 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755942AbbEUPuZ convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 11:50:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,469,1427785200"; d="scan'208";a="496607352" Date: Thu, 21 May 2015 21:21:25 +0530 From: Vinod Koul To: Maninder Singh Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer Message-ID: <20150521155125.GO3140@localhost> References: <1162474717.380131432011625902.JavaMail.weblogic@ep2mlwas07b> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1162474717.380131432011625902.JavaMail.weblogic@ep2mlwas07b> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1716 Lines: 51 On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote: > EP-AA9D1F29B02341529D96C06444D8471D Whats this, please sned patch ina proper format, git format-patch is your friend, use it > > Hi, > Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer patch title doesn't match expectations, use the right subsystem name, and also please explain why yoy are doing this > > Signed-off-by: Maninder Singh > Reviewed-By: Vaneet Narang > --- > drivers/dma/pl330.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a7d9d30..7e27144 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst, > { > struct dma_pl330_desc *desc; > struct dma_pl330_chan *pch = to_pchan(chan); > - struct pl330_dmac *pl330 = pch->dmac; > + struct pl330_dmac *pl330; > int burst; > > if (unlikely(!pch || !len)) > return NULL; > > + pl330 = pch->dmac; > + > desc = __pl330_prep_dma_memcpy(pch, dst, src, len); > if (!desc) > return NULL; > -- > 1.7.1 > > Thanks > Maninder Singh¢éì¹»®&Þ~º&¶¬–+-±éݶ¥Šw®žË›±ÊâmçfiéàŠw¢žØ^n‡r¡ö¦zË?ëh™¨è­Ú&¢ø®G«?éh®(­éšŽŠÝ¢j"?ú¶m§ÿï?êäz¹Þ–Šàþf£¢·hšˆ§~ˆmš Nice signature! -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/