Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757090AbbEUQFG (ORCPT ); Thu, 21 May 2015 12:05:06 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36481 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161031AbbEUPyE (ORCPT ); Thu, 21 May 2015 11:54:04 -0400 From: Mateusz Kulikowski To: gregkh@linuxfoundation.org Cc: Mateusz Kulikowski , dan.carpenter@oracle.com, joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 04/35] staging: rtl8192e: Mark unaligned memcpy() Date: Thu, 21 May 2015 17:53:17 +0200 Message-Id: <1432223628-1664-5-git-send-email-mateusz.kulikowski@gmail.com> X-Mailer: git-send-email 1.8.4.1 In-Reply-To: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com> References: <1432223628-1664-1-git-send-email-mateusz.kulikowski@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2563 Lines: 65 Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential "Fix" to ether_addr_copy(). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index ebb328d..65e4d13 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -488,15 +488,19 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, struct rtllib_rxb **prx * and replace EtherType */ skb_pull(sub_skb, SNAP_SIZE); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN); + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, + ETH_ALEN); /* Must be unaligned */ + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, + ETH_ALEN); /* Must be unaligned */ } else { u16 len; /* Leave Ethernet header part of hdr and full payload */ len = sub_skb->len; memcpy(skb_push(sub_skb, 2), &len, 2); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN); + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, + ETH_ALEN); /* Must be unaligned */ + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, + ETH_ALEN); /* Must be unaligned */ } /* Indicate the packets to upper layer */ @@ -781,15 +785,15 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb, rxb->subframes[0] = sub_skb; - memcpy(rxb->src, src, ETH_ALEN); - memcpy(rxb->dst, dst, ETH_ALEN); + memcpy(rxb->src, src, ETH_ALEN); /* Must stay unaligned */ + memcpy(rxb->dst, dst, ETH_ALEN); /* Must stay unaligned */ rxb->subframes[0]->dev = ieee->dev; return 1; } rxb->nr_subframes = 0; - memcpy(rxb->src, src, ETH_ALEN); - memcpy(rxb->dst, dst, ETH_ALEN); + memcpy(rxb->src, src, ETH_ALEN); /* Must stay unaligned */ + memcpy(rxb->dst, dst, ETH_ALEN); /* Must stay unaligned */ while (skb->len > ETHERNET_HEADER_SIZE) { /* Offset 12 denote 2 mac address */ nSubframe_Length = *((u16 *)(skb->data + 12)); -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/