Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757254AbbEUQHU (ORCPT ); Thu, 21 May 2015 12:07:20 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37178 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466AbbEUQHP (ORCPT ); Thu, 21 May 2015 12:07:15 -0400 Date: Thu, 21 May 2015 12:07:13 -0400 (EDT) Message-Id: <20150521.120713.1811144256149554543.davem@davemloft.net> To: h-shimamoto@ct.jp.nec.com Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org, sy.jong.choi@intel.com, ben@decadent.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter From: David Miller In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05EB460C@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05EB460C@BPXM14GP.gisp.nec.co.jp> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 May 2015 09:07:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 29 From: Hiroshi Shimamoto Date: Thu, 21 May 2015 13:10:49 +0000 > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index 263cb40..b45570f 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -158,6 +158,10 @@ module_param(allow_unsupported_sfp, uint, 0); > MODULE_PARM_DESC(allow_unsupported_sfp, > "Allow unsupported and untested SFP+ modules on 82599-based adapters"); > > +static unsigned int disable_hw_vlan_filter; > +module_param(disable_hw_vlan_filter, uint, 0); > +MODULE_PARM_DESC(disable_hw_vlan_filter, "Disable HW VLAN filter"); Sorry, module parameters like this are not allowed. You must use a generic, portable interface, to configure networking device settings. Otherwise every other driver that wants to do something similar will have yet another module option with a different name, and every user will suffer because they will need to learn a different mechanism to perform this configuration for every driver. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/