Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422720AbbEUQVy (ORCPT ); Thu, 21 May 2015 12:21:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030184AbbEUQVx (ORCPT ); Thu, 21 May 2015 12:21:53 -0400 Message-ID: <555E061C.1020705@redhat.com> Date: Thu, 21 May 2015 18:21:48 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com Subject: Re: [PATCH 08/12] KVM: x86: save/load state on SMM switch References: <1431084034-8425-1-git-send-email-pbonzini@redhat.com> <1431084034-8425-9-git-send-email-pbonzini@redhat.com> <20150521162036.GA31183@potion.brq.redhat.com> In-Reply-To: <20150521162036.GA31183@potion.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 19 On 21/05/2015 18:20, Radim Krčmář wrote: > >> > + set_desc_base(&desc, get_smstate(u32, smbase, offset + 8)); >> > + set_desc_limit(&desc, get_smstate(u32, smbase, offset + 4)); >> > + rsm_set_desc_flags(&desc, get_smstate(u32, smbase, offset)); > (There wan't a layout where this would be right, so we could save the > shifting of those flags in 64 bit mode. Intel P6 was close, and they > had only 2 bytes for access right, which means they weren't shifted.) Check the AMD architecture manual. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/