Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422760AbbEURAH (ORCPT ); Thu, 21 May 2015 13:00:07 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:35476 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422674AbbEURAD convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 13:00:03 -0400 MIME-Version: 1.0 In-Reply-To: <1432161344-1930-1-git-send-email-stefan@agner.ch> References: <1432161344-1930-1-git-send-email-stefan@agner.ch> Date: Thu, 21 May 2015 19:00:02 +0200 Message-ID: Subject: Re: [PATCH soc] ARM: use ARM_SINGLE_ARMV7M for ARMv7-M platforms From: Joachim Eastwood To: Stefan Agner Cc: Arnd Bergmann , Olof Johansson , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Maxime Coquelin , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3029 Lines: 89 Hi Stefan, On 21 May 2015 at 00:35, Stefan Agner wrote: > Use the new config symbol ARM_SINGLE_ARMV7M which groups config > symbols used by modern ARMv7-M platforms. This allows supporting > multiple ARMv7-M platforms in one kernel image. However, a common > kernel image requires the combined platforms to share the same > main memory layout to be bootable. > > Acked-by: Uwe Kleine-König > Signed-off-by: Stefan Agner You should have your sign-off on the top and not Uwe's ack. > --- > Since this is essentially only a shift of config symbols, it > should not change runtime behavior, at least when selecting > only one platform. > > Uwe, this is essentially the same I had in my patchset, just > converting the other platforms too. I was bold and added your > Ack anyway... > > Joachim, Maxime, I test compiled with your defconfigs, compiled > fine on my machine. > > arch/arm/Kconfig | 86 ++++++++++++++++++-------------------------------- > arch/arm/Kconfig.debug | 5 ++- > 2 files changed, 32 insertions(+), 59 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 75920ed..9b777e3 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -334,6 +334,7 @@ config ARM_SINGLE_ARMV7M > depends on !MMU > select ARCH_WANT_OPTIONAL_GPIOLIB > select ARM_NVIC > + select AUTO_ZRELADDR > select CLKSRC_OF > select COMMON_CLK > select CPU_V7M > @@ -411,24 +412,6 @@ config ARCH_EBSA110 > Ethernet interface, two PCMCIA sockets, two serial ports and a > parallel port. [...] > -config ARCH_LPC18XX > - bool "NXP LPC18xx/LPC43xx" > - depends on !MMU > - select ARCH_HAS_RESET_CONTROLLER > - select ARCH_REQUIRE_GPIOLIB > - select ARM_AMBA > - select ARM_NVIC > - select AUTO_ZRELADDR > - select CLKSRC_LPC32XX > - select COMMON_CLK > - select CPU_V7M > - select GENERIC_CLOCKEVENTS > - select NO_IOPORT_MAP > - select PINCTRL > - select SPARSE_IRQ > - select USE_OF > - help > - Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 > - high performance microcontrollers. > - [...] > +config ARCH_LPC18XX > + bool "NXP LPC18xx/LPC43xx" > + depends on ARM_SINGLE_ARMV7M > + select ARCH_HAS_RESET_CONTROLLER > + select ARM_AMBA > + select CLKSRC_LPC32XX > + select PINCTRL > + help > + Support for NXP's LPC18xx Cortex-M3 and LPC43xx Cortex-M4 > + high performance microcontrollers. The LPC18xx parts look good and it still builds and boots on my devkit so; Acked-by: Joachim Eastwood regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/